Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Remove *** from strings in log #103

Open
pjindras opened this issue Jan 9, 2024 · 1 comment
Open

[Feature Request] Remove *** from strings in log #103

pjindras opened this issue Jan 9, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pjindras
Copy link

pjindras commented Jan 9, 2024

Please remove String: ***** the stars in strings in log, its hard to identify false positives etc. in case of regex

example:

[19:23:34] Hráč Deen použil zakázaný výraz: | String: ***** ze mam vytezit 16 zlata a furt mi jeste nedroplo ani jednou :D
[19:30:26] Hráč AmonisCZE použil zakázaný výraz: | String: nvm není **ůj miner ne?

@pjindras pjindras added the enhancement New feature or request label Jan 9, 2024
@4drian3d 4drian3d added the good first issue Good for newcomers label Jan 9, 2024
@4drian3d
Copy link
Owner

4drian3d commented Mar 2, 2024

Implementing a placeholder of the detected string would currently be complicated without breaking API compatibility, so I would have to do it for a major version, but for the moment you can use the placeholder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants