Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project rebuild on config change #110

Closed
wants to merge 3 commits into from
Closed

Conversation

CodeGat
Copy link
Member

@CodeGat CodeGat commented Oct 2, 2023

We currently have a workflow_dispatch trigger on dep-image-1-start.yml, but there aren't many cases in which we would want to run this pipeline outside of the triggers defined on the workflow.
Investigate if we can remove the workflow_dispatch trigger and perhaps replace it with one of the use cases that the workflow_dispatch trigger might have been good for: rebuilding the project when config/models.json or config/compilers.json are updated.
This can involved triggering on pull_request whenever the config directory changes, validating the config files, and running the dep-image pipeline.

Should close #106 !

@CodeGat CodeGat added priority:low A low priority issue - 'nice to haves' or issues that don't impact functionality type:investigation look into options, do some research! labels Oct 2, 2023
@CodeGat CodeGat self-assigned this Oct 2, 2023
@CodeGat CodeGat marked this pull request as ready for review October 5, 2023 01:08
@CodeGat CodeGat marked this pull request as draft October 5, 2023 01:09
@CodeGat CodeGat removed their assignment Mar 15, 2024
@CodeGat CodeGat closed this Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:low A low priority issue - 'nice to haves' or issues that don't impact functionality type:investigation look into options, do some research!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate need for a workflow_dispatch on dep-image-1-start.yml workflow
1 participant