Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koh's faces v2 #31

Open
Amndeep7 opened this issue Sep 5, 2020 · 1 comment
Open

koh's faces v2 #31

Amndeep7 opened this issue Sep 5, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@Amndeep7
Copy link
Owner

Amndeep7 commented Sep 5, 2020

website has some page to submit and via commentface base images plus probably instructions on how to use them

people who are logged in will have their comments posted to reddit / /r/anime / CDF streamed and will replace the syntax with a link to the image with text composited on top + title text as normal

https://github.com/MayorMonty/Snoostorm

primary concern is to figure out hosting - ideal form would be to not have to host all the different images either on my server or on some image host and instead just generate it on the fly based off of the url - not sure how to handle embeds tho which is key esp for adding support to res and the hover over images extension

@Amndeep7
Copy link
Owner Author

Amndeep7 commented Sep 6, 2020

I think it'll be reasonably feasible to support RES but not any of the normal 'hover over' extensions like Imagus. This is because RES supports displaying arbitrary content with iframes whereas Imagus seems to mandate some sort of image filetype. What I was thinking to do would be to host the templates on my end and then use canvas to draw the text on top based on the URL parameters (i.e. the top/bottom text + title text) which would result in a new 'image' but without me having to create and store a jillion different ones; however, it also wouldn't be a url that ends in jpg or gif or whatever which is why Imagus wouldn't work.

https://github.com/honestbleeps/Reddit-Enhancement-Suite/wiki/Adding-new-media-hosts
https://github.com/honestbleeps/Reddit-Enhancement-Suite/blob/master/lib/core/host.js
https://github.com/honestbleeps/Reddit-Enhancement-Suite/blob/master/examples/host.js
https://github.com/honestbleeps/Reddit-Enhancement-Suite/blob/master/lib/modules/hosts/default.js

@Amndeep7 Amndeep7 added the enhancement New feature or request label Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant