Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use collections.deque for memory storage #24

Open
mtreca opened this issue Dec 2, 2020 · 0 comments
Open

Use collections.deque for memory storage #24

mtreca opened this issue Dec 2, 2020 · 0 comments

Comments

@mtreca
Copy link

mtreca commented Dec 2, 2020

Hi,

Just stumbled upon your work yesterday, it provides a very nice starting point for my DQN experiments with SUMO.

A small suggestion (if you care about maintaining this project) would be to use a collections.deque data structure for your memory samples. By specifying a size_max on instantiation, you don't have to manually pop old observations from your memory DB.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant