Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar background scrolling on home page #841 #852

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yashpandav
Copy link

@yashpandav yashpandav commented Jan 7, 2025

Description

This pull request addresses the mobile navigation experience for the website. Specifically, it introduces enhancements to improve usability and ensure a more seamless interaction for users. Key changes include:

  1. Adding functionality to close the menu when a navigation link is clicked or when the user clicks outside the menu area.
  2. Preventing the body from scrolling when the mobile menu is open by applying the menu-open class.
  3. Enhancing the appearance and behavior of the mobile navigation menu with smooth transitions and a full-page overlay effect.

Related Issues

“None”

Type of PR

  • Bug Fixes
  • Extra one functionality

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @yashpandav! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for vintagevibe ready!

Name Link
🔨 Latest commit 7d33f86
🔍 Latest deploy log https://app.netlify.com/sites/vintagevibe/deploys/677d09de3d1d73000803ae8d
😎 Deploy Preview https://deploy-preview-852--vintagevibe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yashpandav
Copy link
Author

@Anjaliavv51, Please review the code and merge the PR. Let me know if any changes are required. Thank you

@yashpandav yashpandav closed this Jan 8, 2025
@yashpandav yashpandav deleted the Navbarbackgroud-scrolling-841 branch January 8, 2025 04:06
@yashpandav yashpandav restored the Navbarbackgroud-scrolling-841 branch January 8, 2025 17:18
@yashpandav yashpandav reopened this Jan 8, 2025
@Anjaliavv51
Copy link
Owner

Anjaliavv51 commented Jan 9, 2025

image

close option is not visible , below it need to be look like even UI is changed , retro word should be visible , make the changes properly

image

@Anjaliavv51 Anjaliavv51 closed this Jan 9, 2025
@Anjaliavv51 Anjaliavv51 reopened this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar background scrolling on home page
2 participants