Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign up page name field validation is missing #844

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Sign up page name field validation is missing #844

wants to merge 1 commit into from

Conversation

ajstarks117
Copy link

Description

The issue was related to adding validation to the Name field in Sign Up page that directly redirects to the register page.
That's why
I Added Name field validation to the sign-up page which was missing along with following validation criteria:

Only alphabetic characters (and optionally spaces or hyphens) are allowed.
Input length is reasonable (e.g., between 2 and 50 characters).
Special characters and numeric inputs are restricted.

resolves: #843

Screenshots / videos (if applicable)

image

image

github-actions[bot]
github-actions bot reviewed Jan 3, 2025
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @ajstarks117! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@netlify Netlify
Copy link

netlify bot commented Jan 3, 2025 •
edited
Loading

✅ Deploy Preview for rococo-mooncake-0d89f7 ready!

Name Link
🔨 Latest commit a34b982
🔍 Latest deploy log https://app.netlify.com/sites/rococo-mooncake-0d89f7/deploys/677826489e555400089aed4f
😎 Deploy Preview https://deploy-preview-844--rococo-mooncake-0d89f7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Anjaliavv51
Copy link
Owner

@ajstarks117 changes are not visible in PR.

image

@Anjaliavv51
Copy link
Owner

@ajstarks117

Screen.Recording.2025-01-05.193151.mp4

@ajstarks117
Copy link
Author

ajstarks117 commented Jan 5, 2025 •
edited
Loading

Ok I'll fix it and look into it

@ajstarks117
Copy link
Author

ajstarks117 commented Jan 5, 2025 •
edited
Loading

@Anjaliavv51 just had a doubt that in validation should it detect whether the user has given a proper name or not?
Because I have added based on use of special characters, and a limit of 2-50 characters that's why the name was considered valid when you gave the input between 2-50 characters.

@Anjaliavv51
Copy link
Owner

@Anjaliavv51 just had a doubt that in validation should it detect whether the user has given a proper name or not? Because I have added based on use of special characters, and a limit of 2-50 characters that's why the name was considered valid when you gave the input between 2-50 characters.

Yes proper name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞[bug]: Sign up page name field validation is missing
2 participants
@ajstarks117 @Anjaliavv51