Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title attribute #274

Open
trf000 opened this issue Sep 19, 2016 · 0 comments
Open

Title attribute #274

trf000 opened this issue Sep 19, 2016 · 0 comments

Comments

@trf000
Copy link
Collaborator

trf000 commented Sep 19, 2016

The title attribute in Menu, Read More in blog and set in image upload in Filecabinet and CKEditor should be removed. Title is not used for images, and actually hinders accessibility for links.

for blog, Blog.php line 399 if you change:
$template['READ_MORE'] = PHPWS_Text::rewriteLink(Icon::get('chevron-circle-down') . ' ' . dgettext('blog', 'Read more'), 'blog',

to something like

$template['READ_MORE'] = PHPWS_Text::rewriteLink(Icon::get('chevron-circle-down') . ' ' . dgettext('blog', 'Read more of '.$this->title.''), 'blog',
you'll get a more meaningful link for the visually impaired.

┆Issue is synchronized with this Asana task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant