Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non optimal powergraph visualisation #39

Open
ArnaudBelcour opened this issue Jul 29, 2022 · 2 comments
Open

Non optimal powergraph visualisation #39

ArnaudBelcour opened this issue Jul 29, 2022 · 2 comments

Comments

@ArnaudBelcour
Copy link
Contributor

We have observed in several experiments that the visualisation offered by the powergraph does not reflect exactly the combinatorics of the solution. This seems to be normal as powergrasp uses some heuristics and can output sub-optimal visualisation.

But as it is also possible that powergrasp outputs optimal visualisation (such as the lipid powergraph in the metage2metabo article), we need to find a way to identify when a visualisation is optimal and when it is not.

A possibility could be to create automatically a list of equations using powernode names to list the generic associations of AND/OR of powernodes. Then using the nodes in each powernodes to compute the combinatorics. This would created the expected combinatorics from the powergraph visualisation.
It could be compared to the observed combinatorics (stored in the community json in the enum_bacteria field). If there is a difference between the two then the powergraph is suboptimal. And if the two are equal then the powergraph is an optimal visualisation of the solution.

Also we have to add this in the readme and doc to avoid people misinterpretating the result of the powergraph.

@ArnaudBelcour
Copy link
Contributor Author

Add a draft of a function to check this in commit 09f9a85.

@ArnaudBelcour
Copy link
Contributor Author

Added a first draft in #61.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant