Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploads do not occur if email process fails #37

Closed
dfornika opened this issue May 17, 2021 · 0 comments · Fixed by #48
Closed

Uploads do not occur if email process fails #37

dfornika opened this issue May 17, 2021 · 0 comments · Fixed by #48
Assignees
Labels
bug Something isn't working

Comments

@dfornika
Copy link
Member

dfornika commented May 17, 2021

In cases where the email sending process fails, an error will be thrown that causes termination of the uploader.

illumina-uploader/utils.py

Lines 107 to 114 in c6b18c9

def sendEmailUsingPlover(emailUrl, args):
'''
Format and add 3 sec delay before sending out email
'''
time.sleep(3)
emailUrl = emailUrl.format_map(args)
emailUrl = emailUrl.replace("|","%7C").replace(" ","%20")
response = urlopen(emailUrl)

When this happens, uploads will not occur. Uploading data takes higher precedence than notifications, so uploads should proceed even when email notifications fail.

@jaideep2 jaideep2 self-assigned this Sep 15, 2021
@jaideep2 jaideep2 added the bug Something isn't working label Sep 15, 2021
@jaideep2 jaideep2 pinned this issue Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants