Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: "06-product-preview" project mobile version image is not correct #27

Closed
beRajeevKumar opened this issue Oct 2, 2024 · 2 comments
Closed

Bug: "06-product-preview" project mobile version image is not correct #27

beRajeevKumar opened this issue Oct 2, 2024 · 2 comments
Assignees
@jjf2009
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers gssoc hacktoberfest Contribute for Hacktoberfest help wanted Extra attention is needed level1 Easy Level

Comments

@beRajeevKumar
Copy link
Collaborator

beRajeevKumar commented Oct 2, 2024 •
edited
Loading

Mobile responsive design is not correct, use the <picture> tag and choose the two images for the different breakpoints.
For desktop design, use "image-product-desktop.jpg" in the images folder.
For mobile design, use "image-product-mobile.jpg" in the images folder.
@beRajeevKumar beRajeevKumar added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest Contribute for Hacktoberfest gssoc level1 Easy Level labels Oct 2, 2024
@jjf2009
Copy link
Contributor

jjf2009 commented Oct 2, 2024

Assign me this issue

@beRajeevKumar
Copy link
Collaborator Author

@jjf2009, Do it 🚀

@jjf2009 jjf2009 mentioned this issue Oct 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjf2009 jjf2009

Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers gssoc hacktoberfest Contribute for Hacktoberfest help wanted Extra attention is needed level1 Easy Level
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@beRajeevKumar @AkshitGarg24 @jjf2009