Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should the FROM statement on this line be referencing the base stage that has the production dependencies and not the dev stage? #264

Open
KyBerry opened this issue Sep 21, 2023 · 1 comment

Comments

@KyBerry
Copy link

KyBerry commented Sep 21, 2023

https://github.com/BretFisher/docker-mastery-for-nodejs/blame/1fdac1a82516b14ebf5ab811e9bda6dc806dafca/typescript/Dockerfile#L19

@BretFisher
Copy link
Owner

In my example, it should reference the dev stage, which has the build tools. Ideally, production images shouldn't have build tools and dependencies in them. You'll see later that I manually copy a directory out of that image to ensure the build tools avoid the production image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants