Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waterfox Classic: reinstate UA string overrides for platforms other than Windows #1260

Closed
grahamperrin opened this issue Nov 9, 2019 · 2 comments

Comments

@grahamperrin
Copy link

For example:

3d73512#diff-61cac4855c1bb1dd3e264ed799753d4fR47

Overrides such as these seem to be missing from Waterfox Classic 2019.10 (20191023220600) on Linux so, for example:

image

This version of Firefox is not supported. Please upgrade to a supported version.

I have not tested Waterfox Classic 2019.10 (20191022184353) on Mac OS X but if I understand correctly (from 02999ce):

  • Macs are similarly bugged.

The need to restore overrides for Linux is explicit near the head of #1203 but the PR there is for minor improvements.

I reckon, the loss of overrides has the potential to be relatively major. Override discussions have been noisy in the past so let's nip this in the bud :-)

Meta, tracking: #538

Side note

Re https://www.reddit.com/comments/bup65x/-/epi08aa/ Trello is probably a fine example of a site that:

  • does not require an OS-specific string
  • accepts terse, in this case:

Firefox/60.0

– and (as usual) given the 56.⋯ essence of Waterfox Classic, I favour 60.0 (as a former ESR) unless there's a known good reason to stretch the pretence higher to 68.0 for a site.

@grahamperrin
Copy link
Author

Yesterday's merge #1203 (comment) noted with thanks.

Is 02999ce#diff-96352d26103d2e2f5d0a8579538d4801R152 (no change) the Mac use case?

I hesitate before closing this issue because reading between the lines of something in Reddit, a few days ago, I got the impression that Mac users, too, were without the usual overrides.

@grahamperrin
Copy link
Author

Fix confirmed, thanks!

Waterfox Classic 2019 12, Manjaro Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant