-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RODARS pipeline #1103
Open
gabrielwol
wants to merge
32
commits into
master
Choose a base branch
from
1088-explore-new-rodars-data
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
RODARS pipeline #1103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ready to review! Will add some more usage examples to readme at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pull request accomplishes:
congestion_events.rodars_locations
is the main view we will be using!rodars_pull.py
daily DAG which runs on Morbius.rodars_functions.py
, including: unnesting json data, converting binary coordinates to postgres readable format, data type conversion.congestion_events.rodars_issues
andcongestion_events.rodars_issue_locations
.on conflict do update
.itsc_factors
schema:direction
,lanesaffectedpattern
,locationblocklevel
,roadclosuretype_new
,roadclosuretype_old
. Used to convert codes to human readable format inissue_locations
view.itsc_factors.lanesaffectedpattern
lookup could use review: I devised thelane_open
,lane_closed
columns to give a numeric interpretation of how many lanes are open/closed. I used 0.5 for partial closures/slowdowns.itsc_factors.get_lanesaffected_sums
which translates these codes into numeric columns for ease of use in the main view. Alanesaffectedpattern
could be something like'LOLCLCWO'
(lane open, lane closed, lane closed, sidwalk open) (Try:SELECT lane_open_auto, lane_closed_auto, lane_open_bike, lane_closed_bike, lane_open_ped, lane_closed_ped, lane_open_bus, lane_closed_bus FROM itsc_factors.get_lanesaffected_sums('LOLCLCWO')
)Issue(s) this solves:
What, in particular, needs to reviewed:
What needs to be done by a sysadmin after this PR is merged