-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress towards coffea 0.7.* update #8
Comments
I've verified that examples 1-5 and 7 are working, though they give different results for the cutflow (but the final graph appears to be the same). Examples 6 and 8 are currently giving different results, and I'm continuing to investigate. Lastly, Dask is currently not working with coffea 0.7, which impedes testing on Dask. |
I've fixed the cutflow issue. |
The update has been completed. All that remains is a viable run on Dask for all of the examples/* files, which I believe coffea-casa still requires a patch for, and then I will merge the 0.7 branch into the main branch. |
@mat-adamec can we add a hack from Nick scikit-hep/coffea#468 in each repository?
I tested it, it works and in such a way we will not have a regression while testing new images or coffee version. |
P.S. please also run them on coffea-casa so we can commit them already cached with generated plots :) |
The hack has been added and the branch has been merged. The update is officially complete! |
I'm in the midst of upgrading to coffea 0.7.* on the coffea-0.7 branch, but given the fact that coffea-casa is still on 0.6.*, I can only test whether it works on futures, which is being grumpy today. Thus, this issue will stay up to track progress and remind me what I still need to do until the upgrade is finished.
So far:
But:
And in the future:
The text was updated successfully, but these errors were encountered: