Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.1+] Machine Room Chunkloading Upgrades #595

Open
1 task done
etmoonshade opened this issue Nov 8, 2024 · 2 comments
Open
1 task done

[1.20.1+] Machine Room Chunkloading Upgrades #595

etmoonshade opened this issue Nov 8, 2024 · 2 comments
Labels
16.x Relates to CM4 betas for 1.16.x 18.x Relates to CM4 for 1.18.x 19.x Relates to CM5 for 1.19.x 20.1 Relates to CM6 for MC 20.1 21.1 Relates to CM7 for MC 21.1 enhancement planned verified Issue has been verified.

Comments

@etmoonshade
Copy link

etmoonshade commented Nov 8, 2024

I am not using performance mods.

  • Confirm

Description

Probably more of a feature request here. It seems odd that a compact machine, designed to be placed in the world, doesn't have chunkloading once you leave it.

It was pointed out to me that this was an intentional decision because folks in multiplayer could abuse compact machines. I agree with the principle, but it seems like the behavior change is odd to have as a default.

Suggestion 1: Automatically chunkload all compact machines, possibly gated behind an option in config.

  • This has the advantage of parity with 1.16.5 or earlier (if I remember correctly) - I found it very confusing when suddenly my machine wasn't working after I left it.
  • The disadvantage, of course, is that if it's not an option, it leaves the abuse loophole open.

Suggestion 2: Have compact machines inherit the chunkloading setting of the chunk where the single block resides.

  • This has the advantage of being fairly transparent - if you're chunkloading your base, the machines in the base work as expected. If you're not, you shouldn't expect the compact machine to work either.
  • The disadvantage (in my mind) is that it still leaves routes for abuse, but I assume a server admin could nuke a single chunk a lot more easily than some jerk placing random machines all over the world. :p

Mod Version

compactmachines-forge-6.0.0.0-nightly.jar

Forge Version

1.20.1 - 47.3.0

Link to Crashlog

n/a

Screenshot (if available)

n/a

How to reproduce

Pretty much as described. Make a compact machine, do something automated in it, leave the machine, and then yell "Y U NO WORK" at it.

@etmoonshade etmoonshade added 19.x Relates to CM5 for 1.19.x bug triage unverified Issue needs to be verified beyond initial report, or due to an old version. labels Nov 8, 2024
@robotgryphon robotgryphon added enhancement verified Issue has been verified. planned 20.1 Relates to CM6 for MC 20.1 and removed bug unverified Issue needs to be verified beyond initial report, or due to an old version. triage 19.x Relates to CM5 for 1.19.x labels Nov 16, 2024
@robotgryphon robotgryphon changed the title 1.20.1 - Compact Machines not automatically chunkloaded [1.20.1+] Machine Room Chunkloading Upgrades Nov 16, 2024
@robotgryphon robotgryphon added 16.x Relates to CM4 betas for 1.16.x 18.x Relates to CM4 for 1.18.x 19.x Relates to CM5 for 1.19.x 21.1 Relates to CM7 for MC 21.1 labels Nov 16, 2024
@robotgryphon
Copy link
Collaborator

This is planned to be added as a new room upgrade, likely in the 21.1 (CM7) lifecycle. The upgrade will be applied directly to rooms, keeping them loaded at all times (machine blocks loaded or not).

@etmoonshade
Copy link
Author

I'll still say that there should be a way to do it without requiring upgrades, mimicking the functionality of versions past. :)

@robotgryphon robotgryphon added this to the 7.x for MC 21.1 milestone Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
16.x Relates to CM4 betas for 1.16.x 18.x Relates to CM4 for 1.18.x 19.x Relates to CM5 for 1.19.x 20.1 Relates to CM6 for MC 20.1 21.1 Relates to CM7 for MC 21.1 enhancement planned verified Issue has been verified.
Projects
None yet
Development

No branches or pull requests

2 participants