Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing python3 support #14

Open
hhyyrylainen opened this issue Jan 5, 2025 · 0 comments · May be fixed by #15
Open

Missing python3 support #14

hhyyrylainen opened this issue Jan 5, 2025 · 0 comments · May be fixed by #15

Comments

@hhyyrylainen
Copy link
Contributor

hhyyrylainen commented Jan 5, 2025 •
edited
Loading

Python2 is getting much harder to install so it would be nice if this repo was updated to work with python 3. I just inspected the fetch-externals script and I think it can be fixed by changing line 32 to be exec(f.read(), globals()) and that seems to make it work with python3 (at least it doesn't seem to be failing with any errors).

I can make a PR of this if there is someone to review it.

Edit: I made the PR as I needed to put it in a fork anyway.
@hhyyrylainen hhyyrylainen linked a pull request Jan 5, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fetch-externals script to work with python3 hhyyrylainen/breakpad-mingw
1 participant
@hhyyrylainen