Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ExploreViewLink from Link component and update props for type safety #304

Open
frano-m opened this issue Dec 31, 2024 · 0 comments
Open
Assignees

Comments

@frano-m
Copy link
Contributor

frano-m commented Dec 31, 2024

Approach

  • Remove ExploreViewLink component from Link component.
  • Revert url type in Link component to string.
  • Remove type safety isURLObjectWithHrefAndQuery and elsewhere.
  • Move ExploreViewLink component to src/components/Links/components.
  • Remove ExploreViewLink component props:
    • url
  • Add ExploreViewLink component props:
    • entityListType, required
    • filters {SelectedFilter[]}, required
    • sorting {ColumnSort[])}, optional
    • grouping {GroupingState}, optional
  • Remove any unnecessary type safety.
@frano-m frano-m changed the title Remove ExploreViewLink from Link component and improve "query" type safety Remove ExploreViewLink from Link component and update component props for improved type safety Dec 31, 2024
@frano-m frano-m changed the title Remove ExploreViewLink from Link component and update component props for improved type safety Remove ExploreViewLink from Link component and update props for improved type safety Dec 31, 2024
@frano-m frano-m changed the title Remove ExploreViewLink from Link component and update props for improved type safety Remove ExploreViewLink from Link component and update props for type safety Dec 31, 2024
@frano-m frano-m removed their assignment Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants