Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Villager Trade Confusion #29

Open
lynaevm opened this issue Oct 6, 2020 · 1 comment
Open

Villager Trade Confusion #29

lynaevm opened this issue Oct 6, 2020 · 1 comment

Comments

@lynaevm
Copy link

lynaevm commented Oct 6, 2020

Hello! I'm using the merchant trade feature of this mod and it is working.... oddly. It is all very easy and smooth except trades are being assigned to the wrong careers.

For example, librarians and cartographers seem to get each others newly-assigned trades. Trades assigned to the fletcher are ending up on the shepherd. I haven't fully tested to see if others are inverting. It only seems to happen within a profession.

My script, for reference:
https://pastebin.com/bdGNNke6

@Mohron
Copy link
Member

Mohron commented Oct 7, 2020

Without having the exact mods and script to replicate the issue you/re seeing, It's hard to really say what might be happening here. This feature was only tested lightly back when it was implemented and is very dependent on Forge/Minecraft to make the actual changes to villager's available trades. There certainly could be a bug on the mod's side, but without knowing exactly what is and is not happening, I can't say for sure.

If trades are only being assigned to one profession but the wrong profession, then the mod may have an error. If the trades show up on multiple, it's likely happening in Forge or Minecraft itself and there won't be much if anything that can be done in the mod.

I'll need the Forge and mods you're using with the script in order to look into it further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants