Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new setting to ignore volumes not annotated #25

Open
Acetolyne opened this issue Nov 20, 2024 · 1 comment
Open

new setting to ignore volumes not annotated #25

Acetolyne opened this issue Nov 20, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Acetolyne
Copy link

Acetolyne commented Nov 20, 2024

Is your feature request related to a problem? Please describe.
Implementing this in a large environment that has volumes that are not expandable is hard because you have to manually add the annotation to lots of pvc's to ignore the volume
ie: add volume.autoscaler.kubernetes.io/ignore: "false" to all the volumes

Describe the solution you'd like
I propose that there is an environment variable like IGNORE_UNLESS_ANNOTATED that has a default of false so that the current workflow is not changed but that can be set to "true" in which case all volumes are ignored except the ones that have the annotation volume.autoscaler.kubernetes.io/ignore: "false"

Describe alternatives you've considered
manually annotating the hundreds of pvc's across multiple clusters

@Acetolyne Acetolyne added the enhancement New feature or request label Nov 20, 2024
@Acetolyne
Copy link
Author

I have created a PR for this feature if you would like to implement it, always good to have some additional testing
#26

Ill see what I can do about helping out with some of the other feature requests as well when I have some time. Thx for considering this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants