-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query which beamlines are available #10
Comments
As an admin? |
And RE |
I might well give it a go, yes, and we should start with admin, but do you think there's value in a query for a regular user being able to ask if their beamline, that they have permission to view, is supported? |
With the current set of OPA rules, a regular user has no concept of 'their beamline'. It'd probably be possible to build a list of beamlines they've previously been on a visit on but it's questionable whether having been on a visit a year ago should still allow them to query beamline info. For the original ticket, there was an |
The other consideration is whether to make a new I'll probably expand the existing query unless you have strong feelings. |
That'd make sense. Make the Or if you want to make the query more complicated but potentially more useful, have an optional field for each configuration option and only return the matching ones? It could be useful to be able to query for 'all beamlines that use template XYZ'. On the other hand, there's a decent argument for not adding anything until there's an actual use for it. |
Yeah probably best not to overpredict. I think more complex queries can come from separate tickets. I'll just make a filter for the beamline for now. On names we will eventually have to reconcile the names in this API with conventional names for entities in the supergraph (so off the top of my head we'll need to rename |
As a user I would like to be able to query which beamlines have configurations so that I can build queries in a discoverable way.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: