-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Check-in] Fix ordered list #689
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Definitely gonna want to squash this one 🙃 |
Don't worry, here we squash everything 🔨 |
@vardizzo-lab This is a cosmetic change -- no change in content. Assigned to you as codeowner - ready for review. |
Last link check was a false positive since it was a link to our confluence which is having a bad day. |
OK, it looks good to me, but ideally we would need to see a proper rendering via the PR preview, but it seems the preview deployment is still broken :/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Documentation preview deployed!Available at https://docs.egi.eu/documentation/689 |
So yes, ikt's finally deployed at https://docs.egi.eu/documentation/689/users/aai/check-in/joining-virtual-organisation/ |
A few remarks/suggestion, while comparing https://docs.egi.eu/documentation/689/users/aai/check-in/joining-virtual-organisation/ with https://docs.egi.eu/users/aai/check-in/joining-virtual-organisation/:
|
Documentation preview deployed!Available at https://docs.egi.eu/documentation/689 |
Closed EGI-Federation#688 Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Closed EGI-Federation#688 Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Signed-off-by: Bruce Becker <[email protected]>
Documentation preview deployed!Available at https://docs.egi.eu/documentation/689 |
Point taken -- however, I wanted to make only cosmetic changes in this ticket, so that it could be approved quickly. 📢 @vardizzo-lab We can make changes to content subsequently, but this will require a functional review from the product owner
Indeed! This is low-impact stuff, let's get it merged. |
Documentation preview deployed!Available at https://docs.egi.eu/documentation/689 |
ping @vardizzo-lab |
Summary
This reformats the ordered list in proper markdown.
Related issue :
Closed #688