Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Check-in] Fix ordered list #689

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

brucellino
Copy link
Member

Summary

This reformats the ordered list in proper markdown.


Related issue :

Closed #688

This comment has been minimized.

@gwarf gwarf added the safe for preview Pull request vetted as safe for preview label Jan 9, 2025

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@brucellino brucellino marked this pull request as draft January 9, 2025 08:29

This comment has been minimized.

@brucellino
Copy link
Member Author

Definitely gonna want to squash this one 🙃

@gwarf
Copy link
Member

gwarf commented Jan 9, 2025

Definitely gonna want to squash this one 🙃

Don't worry, here we squash everything 🔨

@brucellino brucellino marked this pull request as ready for review January 9, 2025 08:50
@brucellino
Copy link
Member Author

@vardizzo-lab This is a cosmetic change -- no change in content. Assigned to you as codeowner - ready for review.

@brucellino
Copy link
Member Author

Last link check was a false positive since it was a link to our confluence which is having a bad day.

@gwarf
Copy link
Member

gwarf commented Jan 9, 2025

OK, it looks good to me, but ideally we would need to see a proper rendering via the PR preview, but it seems the preview deployment is still broken :/
But if @vardizzo-lab approves the PR we can merge it like this.

Copy link
Member

@gwarf gwarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

github-actions bot commented Jan 9, 2025

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/689

@brucellino
Copy link
Member Author

page looks good.
image

@gwarf
Copy link
Member

gwarf commented Jan 9, 2025

@gwarf
Copy link
Member

gwarf commented Jan 9, 2025

A few remarks/suggestion, while comparing https://docs.egi.eu/documentation/689/users/aai/check-in/joining-virtual-organisation/ with https://docs.egi.eu/users/aai/check-in/joining-virtual-organisation/:

  • Ideally the image on the points 2 should go below, I hind it nicer/cleaner
  • The points 5 and so on about pending petitions are not very clear, it may be clarified that it's about an already made request/petition. In fact point 6 may likely be moved before 5. And points 8 and 9 should likely be substeps of the point where there is a pending petition.
    That said all this will change a bit once Keycloack will be intergrated for VO management so...

Copy link

github-actions bot commented Jan 9, 2025

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/689

Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/689

@brucellino
Copy link
Member Author

A few remarks/suggestion, while comparing https://docs.egi.eu/documentation/689/users/aai/check-in/joining-virtual-organisation/ with https://docs.egi.eu/users/aai/check-in/joining-virtual-organisation/:

* Ideally the image on the points 2 should go below, I hind it nicer/cleaner

* The points 5 and so on about pending petitions are not very clear, it may be clarified that it's about an already made request/petition. In fact point 6 may likely be moved before 5. And points 8 and 9 should likely be substeps of the point where there is a pending petition.

Point taken -- however, I wanted to make only cosmetic changes in this ticket, so that it could be approved quickly. 📢 @vardizzo-lab

We can make changes to content subsequently, but this will require a functional review from the product owner

  That said all this will change a bit once Keycloack will be intergrated for VO management so...

Indeed! This is low-impact stuff, let's get it merged.

Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/689

@brucellino
Copy link
Member Author

ping @vardizzo-lab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe for preview Pull request vetted as safe for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Joining a Virtual Organisation -- ordered list is not an ordered list.
3 participants