Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The prettier pre-commit hook is deprecated -- it should be removed #690

Open
brucellino opened this issue Jan 9, 2025 · 0 comments
Open
Assignees
Labels
low priority Low priority tasks

Comments

@brucellino
Copy link
Member

Short Description of the issue

We declare the prettier hook in our pre-commit configuiration. However, this hook has been deprecated since April 2024 and the repository hosting it is archived.
The hook still works, but it will probably not be reliable going forward.

There does not seem to be an alternative prettier hook for the pre-commit framework; prettier themselves do not include it in their documentation.

Summary of proposed changes

I do not propose we follow the Prettier documentation on pre-commit hooks, which invoke a different framework than what we have adopted.
Rather, I suggest we adopt a pre-commit hook configure for the content in question.
Unfortunately, MegaLinter is too big for a pre-commit hook.

@brucellino brucellino self-assigned this Jan 9, 2025
@brucellino brucellino added the low priority Low priority tasks label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Low priority tasks
Projects
None yet
Development

No branches or pull requests

1 participant