Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required permissisons to deploy previews #691

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

gwarf
Copy link
Member

@gwarf gwarf commented Jan 9, 2025

The actions should only be triggered when a label is set, and only selected users can set labels.

As per https://docs.github.com/en/rest/authentication/permissions-required-for-github-apps?apiVersion=2022-11-28#repository-permissions-for-pull-requests, contents: write should be required to push the content to the preview branch, and pull-requests: write should be required for writing the comment.

The actions should only be triggered when a label is set, and only selected users can set labels
@enolfc enolfc added the safe for preview Pull request vetted as safe for preview label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ no-files-to-check 1

See ❌ Event descriptions for more information.

@enolfc
Copy link
Contributor

enolfc commented Jan 9, 2025

Not sure why this is still not correct:
https://github.com/EGI-Federation/documentation/actions/runs/12687215115/workflow#L16

Does it need to be merged first?

Copy link
Contributor

@enolfc enolfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gwarf
Copy link
Member Author

gwarf commented Jan 9, 2025

Not sure why this is still not correct: https://github.com/EGI-Federation/documentation/actions/runs/12687215115/workflow#L16

Does it need to be merged first?

According to https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_run I guess it needs to be merged first: This event will only trigger a workflow run if the workflow file exists on the default branch.

@gwarf gwarf merged commit 8bcd6bf into EGI-Federation:main Jan 9, 2025
9 of 10 checks passed
@gwarf gwarf deleted the fix_preview_deployment branch January 9, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe for preview Pull request vetted as safe for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants