Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[combobox] highlight matching search terms #9026

Closed
1 of 6 tasks
emmilaakso212 opened this issue Apr 1, 2024 · 6 comments
Closed
1 of 6 tasks

[combobox] highlight matching search terms #9026

emmilaakso212 opened this issue Apr 1, 2024 · 6 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Milestone
2024-06-25 - Jun ...

Comments

@emmilaakso212
Copy link

emmilaakso212 commented Apr 1, 2024 •
edited by geospatialem
Loading

Check existing issues

Description

As someone who is searching for an option in the combobox, I want to see how my search matches the options that are being shown.

Acceptance Criteria

When searching using combobox, highlight matching values:

  • by making them Avenir medium, color: text/1
  • by adding a color: foreground/current as a highlight behind them

See designs in Figma

Relevant Info

If there are other components that have a search component, we should be consistent across them. For implementation in 24-R3.

Which Component

Combobox

Example Use Case

Highlighting the search term in filtered results helps people understand why they're seeing an option

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Map Viewer
@emmilaakso212 emmilaakso212 added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Apr 1, 2024
@github-actions github-actions bot added ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. p3 - want for upcoming milestone labels Apr 1, 2024
@emmilaakso212
Copy link
Author

cc: @jcfranco

@driskull
Copy link
Member

driskull commented Apr 2, 2024

I think this would be ideal for the Search widget in the Maps SDK as well.

@geospatialem geospatialem added design Issues that need design consultation prior to development. ready for dev Issues ready for development implementation. labels Apr 18, 2024
@github-actions github-actions bot added the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

cc @geospatialem, @brittneytewks

@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality estimate - 5 A few days of work, definitely requires updates to tests. and removed needs triage Planning workflow - pending design/dev review. labels Apr 18, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 18, 2024
@geospatialem
Copy link
Member

Aiming for dev implementation prior to R3 based on Online priorities - currently targeted for June. cc @emmilaakso212

@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@jcfranco jcfranco self-assigned this May 21, 2024
@jcfranco jcfranco added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 21, 2024
This was referenced May 25, 2024
Closed
Merged
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jun 10, 2024
@jcfranco jcfranco added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible. label Jun 21, 2024
jcfranco added a commit that referenced this issue Jun 24, 2024
@jcfranco
feat(combobox): highlight filter matches (#9425)
0d538c8 
**Related Issue:** #9026

## Summary

Adds highlighting to combobox for the first occurrence of an item's
label that matches the filter text.

### Next steps

For consistency, we can update `list` with similar functionality.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Jun 24, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jun 24, 2024

🍡 Verified on 2.10.0-next.8 👌
combobox-highlight-filter-matches

@DitwanP DitwanP closed this as completed Jun 24, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Map Viewer Issues logged by ArcGIS Map Viewer team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible.
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
5 participants
@jcfranco @driskull @geospatialem @emmilaakso212 @DitwanP