Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide support to edit feature location during report creation process #1038

Open
skrishn opened this issue Nov 26, 2024 · 9 comments
Open
Assignees
Labels
2-ENH New feature or request Reporter 4.x Crowdsource Reporter (new)
Milestone

Comments

@skrishn
Copy link
Collaborator

skrishn commented Nov 26, 2024

Customer reported
"When configuring the Reporter InstantApp, I cannot see it is possible to disable the address search when creating a report.

This becomes an issue particularly when the application is used on a mobile device (or smaller screen). On an iphone, I notice that once an address is searched for when creating a report, a point is automatically dropped, and the screen immediately switches to the report fields for data entry. This is fine and well if the point is in the correct location. But often it is not, and the user is not able to confirm the searched location or move it once the search operation is run. Therefore, the potential that reports will be submitted in incorrect locations is high (especially when location services on a device are turned off or a report is created when the user is not at the location of the report). For my particular use case, reports are being submitted for rural areas on a national forest and often the search is inaccurate (e.g. users may search for 'Lost Lake" and there may be multiple. Or "Baker Draw" may place a point quite a distance from where the report should be located).

On a larger screen size, the map is still shown once the report fields appear, and the point can be moved. Unfortunately, a majority of users in my case are expected to use the app on a mobile device.

It would be beneficial if when configuring the application, the search option can be disabled and/or allow the user to see the map location of the point and confirm/move the point if needed before moving to the report fields for data entry."

@skrishn skrishn added 2-ENH New feature or request Reporter 4.x Crowdsource Reporter (new) labels Nov 26, 2024
@skrishn skrishn added this to the 2025.R01 milestone Nov 26, 2024
@skrishn skrishn self-assigned this Nov 26, 2024
@skrishn
Copy link
Collaborator Author

skrishn commented Nov 26, 2024

Users might still drop a point on the wrong location if search is disable. Moreover, if the user has location enabled, search bar lets them report an issue at their location which is an added convenience.

@skrishn
Copy link
Collaborator Author

skrishn commented Dec 9, 2024

@sumitzarkar For this approach, we're planning to add a 'next' button to the following page, and the user can use the option to confirm the added location before proceeding to the form as opposed to taking them to the form immediately after adding a location. Also, related to this we will be updating designs to include 'cancel' button to be consistent with the user experience across the pages in the report creation workflow. I'll share the designs and updates as its ready.

image

@sumitzarkar
Copy link
Collaborator

@skrishn

This ticket is not assigned to us, if we are planning this for R01 please assign this to me

@skrishn skrishn assigned sumitzarkar and unassigned skrishn Dec 10, 2024
@skrishn skrishn changed the title Disable the address search when creating a report Provide support to edit feature location during report creation process Dec 10, 2024
@sumitzarkar
Copy link
Collaborator

@skrishn @jmhauck

Issue with the Editor widget

  • We use the [Editor] (https://developers.arcgis.com/javascript/latest/api-reference/esri-widgets-Editor.html) widget to create features. However, when a geometry is drawn, the Editor Widget immediately navigates to the feature form, and we are unable to remain on the drawing page after drawing the geometry.
  • In the Editor widget when the template is selected using the template picker page it navigates to the drawing page
  • For drawing a geometry SketchViewModel is used and this is controlled by the Editor widget

Possible Solution

  • So, to overcome this issue we have to control the drawing and create a custom drawing page
  • When the template is selected, we will hide/disable the SketchViewModel of the Editor widget and will create and show our SketchViewModel to draw a geometry.
  • This will be our custom drawing page which will have the next button
  • After the valid geometry is drawn we will enable the next button.
  • In the case of Provide a polygon layer to restrict reporters that can be submitted within a boundary #749 - if the feature is drawn outside the polygon layer we will disable the next button and show the error message on the drawing page
  • When the next button is clicked then we will pass the geometry to the Editor widget and the Feature Form will shown

Could please check with the JS API Team if we are missing anything using which we can control this behavior in the Editor widget directly?

Also, please let us know your thoughts on the Possible solution

@jmhauck
Copy link
Collaborator

jmhauck commented Dec 19, 2024

@chris-fox @skrishn I think its risky to mix ootb widget use and view model use. Sounds like the user is ok with the experience when on larger form factors. So one possibility to consider would be to not go into the fullscreen mode on mobile and just stack the map and editor area. That way they can have the same ability to edit the feature after it's been placed. Then add the ability to expand/collapse the edit form in places like this:

image

If we think some users and use cases are that much better in full screen on mobile that could be supported with a config option to enable/disable mobile full screen.

@sumitzarkar
Copy link
Collaborator

sumitzarkar commented Dec 30, 2024

@jmhauck @skrishn @chris-fox

The main aim is to support editing of a feature location during the report creation process.
To support this we can add the map above the feature form (only in Mobile mode). The entire panel will be scrollable; if required, we can check for ways to collapse/expand the map.
image

@chris-fox
Copy link
Collaborator

@sumitzarkar, @jmhauck, Would the the idea of a next page button work better if we used the FeatureForm widget instead of the Editor widget? I know in a previous call we discussed the use of the FeatureForm widget and the limitations of not being able to add attachments, but I believe this is something that is on the road map.

I don't love the split map/form UI on a mobile device and since this really is a mobile first application I would like to see what we can do to keep the current experience we have for mobile.

@sumitzarkar
Copy link
Collaborator

sumitzarkar commented Jan 7, 2025

@chris-fox @jmhauck @skrishn @azizaparveen

Would the idea of a next page button work better if we used the FeatureForm widget instead of the Editor widget? I know in a previous call we discussed the use of the FeatureForm widget and the limitations of not being able to add attachments, but I believe this is something that is on the road map.
Yes, it will. as we will control the flow.
However, using feature form we see below challenges

  • This will change the create workflow in both Apps Reporter and Manager. Also, this would need major dev and testing efforts.
  • We will not be able to support backward compatibility for those users using functionalities like attachments in the Reporter and Manager app

I don't love the split map/form UI on a mobile device and since this really is a mobile first application I would like to see what we can do to keep the current experience we have for mobile.

  • If we don't want map to be always visble in the featureForm in mobile mode we can add a button which will show/hide the map.
Feature Form with toggle button Map when toggle form is clicked
image image

Please let us know if this works

@skrishn skrishn modified the milestones: 2025.R01, 2025.R02 Jan 10, 2025
@chris-fox
Copy link
Collaborator

We need some more time to think about this and issue #749, going to move to R2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-ENH New feature or request Reporter 4.x Crowdsource Reporter (new)
Projects
None yet
Development

No branches or pull requests

4 participants