[On-Hold for Mentions #379005][$500] [LOW] Save the world - The email refers to people by email address + grammar issue

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.97.0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation: @

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Click on the FAB button
3. Click on the "Save the word" button
4. Click on the "I know a teacher" button
5. Fill in all fields
6. Click on the "Let's do this!" button
7. Open your email app

Expected Result:

The mail should start with "Hey".
If the name of the sender and teacher is known (filled out before sending) the email should refer them by name.

Actual Result:

The email for the teacher starts with ": Hey".
It refers to both the sender and the teacher by email address.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6269778_1699525640410.bandicam_2023-11-08_06-04-08-387.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019c866a41051c1129
• Upwork Job ID: 1722577721011531776
• Last Price Increase: 2023-11-09

Issue Owner

Current Issue Owner: @roryabraham

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019c866a41051c1129

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[erquhart]

Not seeing email templates in Expensify's OSS repos, guessing this is an internal issue.

[CortneyOfstad]

Yeah, thinking this would be internal — going to get engineering eyes on this 👍

[melvin-bot]

Triggered auto assignment to @roryabraham (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

@CortneyOfstad, @sobitneupane, @roryabraham Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[erquhart]

This is internal but Help Wanted label is still applied.

[melvin-bot]

@CortneyOfstad, @sobitneupane, @roryabraham Whoops! This issue is 2 days overdue. Let's get this updated quick!

[CortneyOfstad]

@roryabraham any ideas with this one?

[CortneyOfstad]

Bump @roryabraham — TIA!

[roryabraham]

Ok, so this happens because the HTML in question looks like this:

const string whisperMessageForTeacher = "Hey <mention-user>@" + partnerUserID + "</mention-user>! Your friend <mention-user>@" + inviterEmail + "</mention-user> referred you to Expensify.org's latest campaign which helps teachers and their students. Our Teachers Unite campaign splits teachers' out-of-pocket expenses for essential school supplies. <a href=\"" + AuthCommand::getURLToNewDot() + "teachersunite/i-am-a-teacher\" rel=\"noreferrer noopener\">Click on Save The World</a> in the app's main menu to sign up now and start splitting your expenses with Expensify.org!";

This displays in-product as a mention, which by our current design does not use displayName at all, and instead just uses the full email. There was a ton of discussion about this but I think we went with full emails for simplicity in the V1. cc @puneetlath

So if we wanted to change this it would need to be a broader discussion around mentions in general

[roryabraham]

My main questions here are:

• Do we care about this issue?
• Why did we end up always using full emails for mentions? Is that a long-term plan? Whatever happened to this nice mockup?
• If we don't have any plans to update how mentions are displayed in-product, should we hack something up to inject displayNames for mentions in emails?

[CortneyOfstad]

Doc is still being reviewed so no update 👍

[CortneyOfstad]

Doc still being reviewed!

[CortneyOfstad]

No update for the on-hold issue

[CortneyOfstad]

Still no update on the on-hold issue. David just bumped them here, so will continue to monitor 👍

[CortneyOfstad]

They are chugging along! Only a handful of issues left, so will close this as soon as those are done!

[CortneyOfstad]

Only a small amount still left!

Project link here

[CortneyOfstad]

Only 3 issues left 😍

[CortneyOfstad]

Per this comment, there are two issues that are backlog, which will delay this a bit. However, good progress across the board! 🎉

[CortneyOfstad]

Getting close! Most recent comment is here

[CortneyOfstad]

No update on on-hold issue

[CortneyOfstad]

Latest update is here!

[CortneyOfstad]

Only two bugs left! 🎉

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[CortneyOfstad]

Waiting on this last bug 🎉

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[CortneyOfstad]

Still waiting on Expensify/react-native-live-markdown#317

[mvtglobally]

Issue not reproducible during KI retests. (Third week)

[mvtglobally]

Issue not reproducible during KI retests. (Fourth week)

[mvtglobally]

Issue not reproducible during KI retests. (Fifth week). Can we close this?