Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Add onboarding for new workspaces being created] Create new setup tasks when users create a workspace #53509

Open
francoisl opened this issue Dec 4, 2024 · 19 comments
Assignees
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@francoisl
Copy link
Contributor

Part of the project "Adding onboarding for new workspaces being created"

Main issue: #48591
Doc section: https://docs.google.com/document/d/19u6ZQbNuF-v5oovIkQlmwYV4SXeAgey50pymsj5QHRY/edit?tab=t.0#heading=h.vwt3yefp8jmh (External only)

Feature Description

When a user who didn't choose the option "Manage my team's expenses" during the initial onboarding eventually creates a workspace, create onboarding tasks to teach them what to do next.

Implementation steps

  1. Prep work:

    1. Add new constant newDotTrackWorkspace to backendOnboardingChoices - Design doc section
    2. Extract the logic to generate the request and optimistic data for onboarding tasks out of completeOnboarding(), for clarity and reusability – Design doc section
  2. Create new setup tasks when users create a workspace

    • Design doc section ('External' section only)
    • Update CategorizeTrackedExpense, ShareTrackedExpense, and CreateWorkspace to generate and pass the new onboarding task data to the API if the user doesn't already have a createWorkspace onboarding task
@francoisl francoisl added the Internal Requires API changes or must be handled by Expensify staff label Dec 4, 2024
@francoisl francoisl self-assigned this Dec 4, 2024
@francoisl
Copy link
Contributor Author

(Keeping internal because we're going to work with a C+ on this)

@mananjadhav
Copy link
Collaborator

Reviewed the design document. Will take another pass to see if there are any gaps. Will start with the implementation by tomorrow.

@melvin-bot melvin-bot bot added the Monthly KSv2 label Dec 9, 2024
@francoisl francoisl added Daily KSv2 and removed Monthly KSv2 labels Dec 9, 2024
@mananjadhav
Copy link
Collaborator

@francoisl Is there anything pushed on the backend to start this?

@francoisl
Copy link
Contributor Author

One part is deployed, another one won't be until at least tomorrow, and the tasks won't be saved until both parts are.

For now, the part 1 "Prep work" I described above shouldn't require any backend changes. Also, for step 2 we can start saving the task data in the optimistic data of the API request, and test it offline?

@francoisl
Copy link
Contributor Author

@mananjadhav the backend changes for passing guidedSetupData and engagementChoice to the API commands CategorizeTrackedExpense, ShareTrackedExpense, and CreateWorkspace are now live. Let me know if anything is not working as expected.

@mananjadhav
Copy link
Collaborator

Okay thanks. I'll check those and reach out to you if any questions.

@mananjadhav
Copy link
Collaborator

Started with this, the PR will be up by tomorrow.

@melvin-bot melvin-bot bot added the Overdue label Dec 18, 2024
Copy link

melvin-bot bot commented Dec 19, 2024

@francoisl, @mananjadhav Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mananjadhav
Copy link
Collaborator

I was out sick yesterday. I am half done, will finish this by weekend.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 19, 2024
@anmurali
Copy link

@mananjadhav - do you have an update on this PR?

Copy link

melvin-bot bot commented Dec 24, 2024

@francoisl, @mananjadhav Huh... This is 4 days overdue. Who can take care of this?

@mananjadhav
Copy link
Collaborator

Apologies I was unwell. I am just getting back and will have this ready in 1-2 days.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 24, 2024
@danielrvidal
Copy link
Contributor

Thank you @mananjadhav, let us know if you need anything from our side!

Copy link

melvin-bot bot commented Dec 30, 2024

@francoisl, @mananjadhav Eep! 4 days overdue now. Issues have feelings too...

@mananjadhav
Copy link
Collaborator

PR work in progress. Will be raising the draft today.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Dec 30, 2024
@francoisl
Copy link
Contributor Author

Sounds good, feel free to send it my way even if it's not fully ready, I can start taking a look and testing.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jan 2, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

@francoisl, @mananjadhav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@anmurali
Copy link

@ishpaul777 have you gotten started with a PR?

@melvin-bot melvin-bot bot added the Overdue label Jan 10, 2025
@ishpaul777
Copy link
Contributor

yes here it is -> #55017, sorry forgot to link issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

5 participants