Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvements in iOS codebase #575

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Minor improvements in iOS codebase #575

merged 2 commits into from
Dec 10, 2024

Conversation

tomekzaw
Copy link
Collaborator

@tomekzaw tomekzaw commented Dec 9, 2024

Details

This PR introduces several minor changes (mostly renames) in iOS codebase:

-withAttributes:(nullable NSDictionary<NSAttributedStringKey, id>*)attributes
+withDefaultTextAttributes:(nonnull NSDictionary<NSAttributedStringKey, id> *)defaultTextAttributes
-parse:(NSString *)text
+parse:(nonnull NSString *)text

Related Issues

GH_LINK

Manual Tests

Linked PRs

@tomekzaw tomekzaw requested a review from j-piasecki December 9, 2024 12:46
@tomekzaw tomekzaw requested review from j-piasecki and removed request for j-piasecki December 9, 2024 14:23
@tomekzaw tomekzaw merged commit 066dd14 into main Dec 10, 2024
5 checks passed
@tomekzaw tomekzaw deleted the @tomekzaw/minor-ios-improvements branch December 10, 2024 10:49
@os-botify
Copy link
Contributor

os-botify bot commented Dec 10, 2024

🚀 Published to npm in 0.1.204 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-piasecki j-piasecki j-piasecki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomekzaw @j-piasecki