Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple datagen entrypoints step on each other #4330

Open
skycatminepokie opened this issue Dec 27, 2024 · 1 comment · May be fixed by #4339
Open

Multiple datagen entrypoints step on each other #4330

skycatminepokie opened this issue Dec 27, 2024 · 1 comment · May be fixed by #4339
Labels
bug Something isn't working priority:low Low priority PRs that don't immediately need to be resolved

Comments

@skycatminepokie
Copy link

Having multiple datagen entrypoints causes them to step on each other, deleting each other's stuff depending on the order they're added to the fabric.mod.json. Using the latest for 1.21.
@modmuss50
Copy link
Member

Im not sure this is a supported usecase atm, this is happening becuase each entrypoint gets its own FabricDataGenerator instance, when the vanilla datageneration is ran it will delete files that were not generated by the current data generator. Fixing this doesnt look to be that easy.

@modmuss50 modmuss50 added bug Something isn't working priority:low Low priority PRs that don't immediately need to be resolved labels Dec 30, 2024
@modmuss50 modmuss50 linked a pull request Dec 30, 2024 that will close this issue
Draft
This was referenced Dec 31, 2024
Draft
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority:low Low priority PRs that don't immediately need to be resolved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use a single datagen cache for all entrypoints. modmuss50/fabric
2 participants
@modmuss50 @skycatminepokie