Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the sync-url flag respect iliasignore #38

Open
funnym0nk3y opened this issue Nov 22, 2022 · 4 comments
Open

Make the sync-url flag respect iliasignore #38

funnym0nk3y opened this issue Nov 22, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@funnym0nk3y
Copy link
Contributor

It seems to me that the .iliasignore file is not respected when using the --sync-url flag. I use the flag for syncing a course before the lecture on my notebook instead of crawling all other courses. Thus, I'd like it to respect excluded folders from the .iliasignore.
@FliegendeWurst FliegendeWurst added the question Further information is requested label Nov 22, 2022
@FliegendeWurst
Copy link
Owner

The .iliasignore file is not ignored. Do you have an additional .iliasignore file for the course?

For example, if you usually download all courses into ./ILIAS and want to download a specific course in ./ILIAS/Analysis I, the downloader will certainly read ./ILIAS/Analysis I/.iliasignore. Did you expect the downloader to consider ./ILIAS/.iliasignore?

@funnym0nk3y
Copy link
Contributor Author

Exactly, I did expect it to use ./ILIAS/.iliasignore, even though I invoked the command for a specific course folder.

FliegendeWurst added a commit that referenced this issue Nov 23, 2022
@FliegendeWurst
feat: respect .iliasignore files in parent folder
cc7dcd6 
see #38
@FliegendeWurst FliegendeWurst added enhancement New feature or request and removed question Further information is requested labels Nov 23, 2022
@FliegendeWurst
Copy link
Owner

Ah, got it. Your suggestion is implemented in the latest commit. Feel free to install it using cargo install --git 'https://github.com/FliegendeWurst/KIT-ILIAS-downloader. I'll probably release a new version soon.

@funnym0nk3y
Copy link
Contributor Author

Thank you very much! I'll try it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FliegendeWurst @funnym0nk3y