Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency #626

Closed
wants to merge 10 commits into from
Closed

Update dependency #626

wants to merge 10 commits into from

Conversation

CaoGiaHieu-dev
Copy link

What does this change?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #625 🎯

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
    • Ensure the tests (melos run test)
    • Ensure the analyzer and formatter pass (melos run format to automatically apply formatting)
  • Appropriate docs were updated (if necessary)

@AlexV525
Copy link
Member

AlexV525 commented Jan 8, 2025

I tried to upgrade it before, and it was caused by another package. Please fix all integrations first.

@codecov Codecov
Copy link

codecov bot commented Jan 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.05%. Comparing base (33ff3df) to head (4523453).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #626   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files          21       21           
  Lines         822      822           
=======================================
  Hits          806      806           
  Misses         16       16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CaoGiaHieu-dev
Copy link
Author

@AlexV525 hi . can you check this again

AlexV525
AlexV525 requested changes Jan 8, 2025
View reviewed changes
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert not relevant changes.

examples/example/pubspec.yaml Outdated Show resolved Hide resolved
examples/example/pubspec.yaml Outdated Show resolved Hide resolved
examples/example/pubspec.yaml Outdated Show resolved Hide resolved
examples/example_resources/pubspec.yaml Outdated Show resolved Hide resolved
examples/example_resources/pubspec.yaml Outdated Show resolved Hide resolved
packages/core/pubspec.yaml Outdated Show resolved Hide resolved
packages/core/pubspec.yaml Outdated Show resolved Hide resolved
packages/core/pubspec.yaml Outdated Show resolved Hide resolved
packages/runner/pubspec.yaml Outdated Show resolved Hide resolved
packages/runner/pubspec.yaml Outdated Show resolved Hide resolved
@CaoGiaHieu-dev
Copy link
Author

Please revert not relevant changes.

Fixed .

@AlexV525
Copy link
Member

AlexV525 commented Jan 9, 2025

I've taken a deeper look at this request, it seems to be covered by #615 already. The only thing we might do is upgrade the package:lottie in the example.

@CaoGiaHieu-dev
Copy link
Author

I've taken a deeper look at this request, it seems to be covered by #615 already. The only thing we might do is upgrade the package:lottie in the example.

could you take a look on my issue . because it was said that flutter_gen still using 2.x.x that make a confict with freezed (or other) package .

@AlexV525
Copy link
Member

AlexV525 commented Jan 9, 2025

could you take a look on my issue . because it was said that flutter_gen still using 2.x.x that make a confict with freezed (or other) package .

This is because #615 is not yet published. You shall not see related issues by using the dependency on the main branch.

@CaoGiaHieu-dev
Copy link
Author

could you take a look on my issue . because it was said that flutter_gen still using 2.x.x that make a confict with freezed (or other) package .

This is because #615 is not yet published. You shall not see related issues by using the dependency on the main branch.

oh . in that case it could resolve my issue without this pr . feel free to close this .
Thank you for your time

@AlexV525
Copy link
Member

AlexV525 commented Jan 9, 2025

Thanks for the contribution anyway!

@AlexV525 AlexV525 closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasabeef wasabeef Awaiting requested review from wasabeef wasabeef is a code owner

@lcdsmao lcdsmao Awaiting requested review from lcdsmao lcdsmao is a code owner

@AlexV525 AlexV525 Awaiting requested review from AlexV525 AlexV525 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Package Dependency
2 participants
@CaoGiaHieu-dev @AlexV525