-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cfpq_pyalgo
package
#27
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting `cfpq_pyalgo` package creation
vadyushkins
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
help wanted
Extra attention is needed
labels
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
help wanted
Extra attention is needed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @IlyaEp !
I think it's time to put all the algorithms into a single package.
Actually, this PR will close #23.
I propose to carry out all refactoring by means of pull requests to the
cfpq_pyalgo_package
branch.I also propose to discuss all emerging issues on refactoring in the comments to this pull request.
Here I will write a small map of what is already done and what else needs to be done as it seems to me.
Package content
src / graph
class Graph
class IndexGraph
class LabelGraph
src.graph.label_graph.LabelGraph
->cfpq_pyalgo.pygraphblas.classes.booleanmatrixgraph.BooleanMatrixGraph
Startingcfpq_pyalgo
package creation #26src / grammar
class CnfGrammar
src.grammar.cnf_grammar.CnfGrammar
->cfpq_pyalgo.classes.cnf.CNF
Startingcfpq_pyalgo
package creation #26class RecursiveAutomaton
src / problems / Base
class MatrixBaseAlgo
src.problems.Base.algo.matrix_base.matrix_base.MatrixBaseAlgo
->cfpq_pyalgo.pygraphblas.all_pairs_reachability.all_pairs_reachability_matrix()
Startingcfpq_pyalgo
package creation #26src / problems / MultipleSource
class MatrixMSBruteAlgo
class MatrixMSOptAlgo
class TensorMSAlgo
class TensorMSAllAlgo
src / problems / SinglePath
class MatrixSinglePath
class MatrixSingleAlgo
src / problems / AllPaths
class MatrixAllAlgo
class TensorSimpleAlgo
class TensorDynamicAlgo
class TensorExtractSubGraph
class TensorPathsNew
class TensorPaths
Docstrings and doctests(examples)
Package content
after refactoringUnit tests
Package content
after refactoringActions
CircleCI
toGitHub Actions
Startingcfpq_pyalgo
package creation #26cfpq_pyalgo
package creation #26cfpq_pyalgo
package creation #26