Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

No underscores in query params. #271

Open
nbwoodward opened this issue Feb 22, 2018 · 1 comment
Open

No underscores in query params. #271

nbwoodward opened this issue Feb 22, 2018 · 1 comment

Comments

@nbwoodward
Copy link

nbwoodward commented Feb 22, 2018

Maybe this isn't a big deal, but it was driving me crazy for a while. If I put an underscore in a route parameter, it doesn't match.

routes = { '/location/location_id':{}, '/location/locationid':{} }

For the url /location/10

<Fragment forRoute='/location/:locationid'><div>This matches.</div></Fragment> <Fragment forRoute='/location/:location_id'><div>This doesn't match.</div></Fragment>

Cheers,
Nick
EDIT: Also, thanks for making this router, I think it's a great addition to the react/redux stack.

@cesarp
Copy link

cesarp commented May 3, 2018

I believe it is documented but not in a clear way in the Wiring up the boilerplate section. In the code snippet it says that for URL matching it is using https://github.com/snd/url-pattern and if you go to its documentation you will see which characters are supported.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants