Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads-up: -Csoft-float is deprecated #63

Open
RalfJung opened this issue Nov 13, 2024 · 1 comment
Open

Heads-up: -Csoft-float is deprecated #63

RalfJung opened this issue Nov 13, 2024 · 1 comment

Comments

@RalfJung
Copy link

This repo uses the -Csoft-float flag here:

This flag is a NOP on most targets, and quite dangerous on 32bit ARM *hf targets unless you build your own standard library also with that flag. For this reason, the flag is being deprecated. See rust-lang/rust#129893 for context.

If you are crucially relying on this flag on a target where it actually has an effect (i.e., a 32bit ARM *hf target), we'd like to hear about that. :) If not, we'd recommend to remove this flag so that you won't get deprecation warnings when Rust 1.83 is released.

@JohnAZoidberg
Copy link
Member

Thanks!
We're not targeting ARM, especially not 32bit in this repository, so it won't be a problem.
But I think we can remove it similarly to system76/firmware-update#120.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants