Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine saved H264 and Opus into a single playable file #12

Open
clone1018 opened this issue Mar 2, 2023 · 1 comment
Open

Combine saved H264 and Opus into a single playable file #12

clone1018 opened this issue Mar 2, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@clone1018
Copy link
Member

Once we have #10 and #11 we can combine them into a singular playable file which is a recording of the entire stream. Likely wont be easy, lots to figure out!

Need to double check H264 and Opus is a good way to go for actual files...

@clone1018 clone1018 added the enhancement New feature or request label Mar 2, 2023
@nassah221
Copy link
Collaborator

I have some thoughts on how we could go about this.

  1. Write h264 (video) and opus (audio) files on to the disk. After the stream ends, combine them into playable container format.
  2. Write and combine video and audio as they are being written to disk.

With the former, there can be a trigger to the action of a stream "ending" that should start the process of packing the media into the desired container format. This warrants further discussion about whether we want decouple the "packing into container" process from the waveguide server, treating it as background job per stream. As far as I understand, this process is fallible/interruptable in which case there should be some retry/timeout mechanism to gracefully handle it.

On the other hand, I think there's going to be a lot of needless complexity with the latter approach with little upside unless there's a usecase to have the "packed" media available in real-time i.e. as soon as the stream ends.

wdyt @clone1018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants