Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locales for Scotland & Northern ireland #88

Open
yrro opened this issue Aug 11, 2022 · 1 comment
Open

Locales for Scotland & Northern ireland #88

yrro opened this issue Aug 11, 2022 · 1 comment
Labels

Comments

@yrro
Copy link

yrro commented Aug 11, 2022

The UK is divided into four countries: England (ISO 3166-2 GB-ENG), Wales (GB-WLS), Scotland (GB-SCT) and Northern Ireland (GB-NIR; actually ISO 3166-2 describes GB-NIR as a province not a country... it doesn't matter for the purposes of holiday data).

England and Wales have the same set of public holidays, currently represented by the en-GB locale. But Scotland and Northern Ireland have different sets.

The data set currently doesn't have any subdivisions below the level of an ISO 3166-1 country. So it's not clear how to extend the dataset to incorporate public holidays in Scotland or Northern Ireland.

@yrro yrro added the locale label Aug 11, 2022
@lauft
Copy link
Member

lauft commented Aug 11, 2022

England, Wales, Scotland, and Northern Ireland should be modeled as regions ENG, WLS, SCT, and NIR in the locale. The holidays then have to be assigned to the specific regions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants