Issues

• labeled_waterfall modifies data in place

  HERA-Team/uvtools#180 · Filter by author zacharymartinot opened on Dec 6, 2024

• Remove existing filtering code and import hera_filters instead

  HERA-Team/uvtools#179 · Filter by author tyler-a-cox opened on Dec 5, 2024

• Fix readme badges

  HERA-Team/uvtools#148 · Filter by author bhazelton opened on Jun 16, 2022

• Upgrade plot.labeled_waterfall

  HERA-Team/uvtools#147 · Filter by author r-pascua opened on Jun 8, 2022
  

• Allow an option to use DPSS to filter the time and frequency axes simultaneously

  HERA-Team/uvtools#142 · Filter by author tyler-a-cox opened on Mar 29, 2022

• Remove hera_sim dependence

  HERA-Team/uvtools#137 · Filter by author aewallwi opened on Sep 17, 2021

• Have lin-leastsq use solutions from adjacent times, frequencies, and redundant group elements to speed up convergence.

  HERA-Team/uvtools#133 · Filter by author aewallwi opened on Jun 18, 2021

• Move skip_contiguous_flags, max_contiguous_flags, skip_if_flag_within_wedge_distance from hera_cal.vis_clean.fourier_filter into uvtools.dspec.fourier_filter

  HERA-Team/uvtools#129 · Filter by author aewallwi opened on May 12, 2021

• Make these their own tests.

  HERA-Team/uvtools#127 · Filter by author aewallwi opened on May 3, 2021

• Make these their own tests.

  HERA-Team/uvtools#126 · Filter by author aewallwi opened on May 3, 2021

• Rather than do a loop that tests many choices of window function, this should be parametrized. It should also be broken up into multiple test functions--one that tests basic parameters (e.g. window length, type, and range), and one that tests normalization. There's certainly a way to parametrize fixtures so that you don't need to repeat code when parametrizing over windows, though I don't remember how to do it off the top of my head. Here's a quick example of one such rewrite:

  HERA-Team/uvtools#125 · Filter by author aewallwi opened on May 3, 2021

• These should be separate tests, e.g. test_calc_width_single_filter_size and test_calc_width_bandpass (or something to that effect).

  HERA-Team/uvtools#124 · Filter by author aewallwi opened on May 3, 2021

• Too many assertions.

  HERA-Team/uvtools#123 · Filter by author aewallwi opened on May 3, 2021

• Make these their own tests. I like to make error tests very specific, so it's obvious when things in the code have been changed. For example, suppose the function func raises a ValueError with error message msg when ran with parameters args. I would then write a test along the lines of

  HERA-Team/uvtools#122 · Filter by author aewallwi opened on May 3, 2021

• Too many assertions for a single test.

  HERA-Team/uvtools#121 · Filter by author aewallwi opened on May 3, 2021

• This can be greatly simplified by use of parametrization. I'd also *strongly* recommend against running more than one assert statement per test.

  HERA-Team/uvtools#120 · Filter by author aewallwi opened on May 3, 2021

• Since these parameters are reused, it would make sense to make them fixtures (or global variables, but that's not as neat). As an example, you would do something like

  HERA-Team/uvtools#119 · Filter by author aewallwi opened on May 3, 2021

• Again with multiple assertions per test. A test should only have a single point of failure, otherwise it isn't very helpful when it comes to debugging.

  HERA-Team/uvtools#118 · Filter by author aewallwi opened on May 3, 2021

• Plot horizon in fourier_transform_waterfalls

  HERA-Team/uvtools#109 · Filter by author r-pascua opened on Jan 15, 2021
  

• Improve plot.labeled_waterfall

  HERA-Team/uvtools#108 · Filter by author r-pascua opened on Jan 8, 2021
  

• CLEAN with multiple disjoint regions does not work.

  HERA-Team/uvtools#104 · Filter by author aewallwi opened on Sep 30, 2020

• subtract weights times resid to compute dayenu model in fourier filter

  HERA-Team/uvtools#101 · Filter by author aewallwi opened on Aug 8, 2020

• More flexible 2d clean areas

  HERA-Team/uvtools#99 · Filter by author aewallwi opened on Aug 6, 2020

• Style enforcement

  HERA-Team/uvtools#98 · Filter by author aewallwi opened on Aug 6, 2020

• add rect 2d filtering mode to _fit_basis_2d

  HERA-Team/uvtools#95 · Filter by author aewallwi opened on Aug 5, 2020