Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component Structure #20

Open
trentgoing opened this issue Jul 10, 2020 · 0 comments
Open

Component Structure #20

trentgoing opened this issue Jul 10, 2020 · 0 comments

Comments

@trentgoing
Copy link

trentgoing commented Jul 10, 2020 •
edited
Loading

Project-Greenfield/client/src/components/RatingsAndReviewsComponents/ReviewBreakdown.jsx

Line 122 in b07b2fb

const productBreakdownBar = (characteristics) => {

You have a great organization to your components throughout the widget. Part of the reason it is nice to read through is it aligns to the ideas outlined here: https://medium.com/@dan_abramov/smart-and-dumb-components-7ca2f9a7c7d0. Where the responsibility of display is separated from state management.

Good job structuring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trentgoing