Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brushes: remove selection indicator once brush settings change #504

Open
humdingerb opened this issue Apr 7, 2023 · 3 comments
Open

Brushes: remove selection indicator once brush settings change #504

humdingerb opened this issue Apr 7, 2023 · 3 comments
Labels
brushes issues related to brushes enhancement

Comments

@humdingerb
Copy link
Member

You click on a stored brush, then change size/apect/etc. That's doesn't change the selected brush, but creates a new "current brush" (which could be stored as a new brush).
The selection indicator of the stored brush should therefore be removed.

As collateral damage, the menu item "Delete selected brush" would then need to be disabled, too.

@dsizzle
Copy link
Collaborator

dsizzle commented May 7, 2023

pulled from comments on PR #518 -

"Reset brush" should remove any selection from the stored brushes (except if you have stored a brush with the "Reset" settings, then it should be selected).

@dsizzle
Copy link
Collaborator

dsizzle commented May 28, 2023

what if you change the settings and it matches an existing brush? Should that be selected? I wonder if checking all the brushes every time you change a setting could be slow, if you have a large number of brushes.

@humdingerb
Copy link
Member Author

Come to think of it, there's really not much use in having a stored bush selected if you hit upon identical settings.
I wonder though how best to deal with the user trying to store the brush, if there's already one with identical settings.
Say, there are 12 stored brushes, the user clicks "Store brush" and expects a 13th to appear. Instead brush 7 is selected. Is that intuitive or surprising?

@dsizzle dsizzle added enhancement brushes issues related to brushes labels Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
brushes issues related to brushes enhancement
Development

No branches or pull requests

2 participants