Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download progress / pause issue #2239

Open
d3d43 opened this issue Dec 20, 2022 · 14 comments
Open

Download progress / pause issue #2239

d3d43 opened this issue Dec 20, 2022 · 14 comments

Comments

@d3d43
Copy link

d3d43 commented Dec 20, 2022

Describe the bug

I paused a download due to changing vpn server. However after this, i cannot tell if the download restarted from the beginning or what.

The download progress bar as of now appears that the download restarted from the beginning, but viewing previous threads suggests otherwise and that heroic has the ability to pause a download in between and resuming after.

Despite this, the completed section appears that the previous download which i left overnight for has been cancelled, and that the current download says 59% complete which is representative of the currently downloaded file size. All this happened despite the fact that i pressed "Keep downloaded files" when attempting to pause.

The issue is quite frustrating as i feel like i have wasted 6 hours trying to download a file only to be wiped.

Add logs

not available. comment too long

Steps to reproduce

  1. Go to '...'
  2. Click on '...'
  3. Scroll down to '...'
  4. See error

Expected behavior

Display correct percentage of download, if the pause download was successful.

Display real pause button that functions properly and does not result in confusion for the end user.

Screenshots

image

Heroic Version

Latest Stable

System Information

Macos monterey 12.3.1
Apple m1 macbook air

Additional information

No response

@evnct
Copy link

evnct commented Jan 16, 2023

You are right. It is currently a bit confusing.

If the user chooses to keep the files, it should not say (cancelled). It should say (Paused). Currently when the user clicks on the "cancelled" game it will display Install option afterwards but instead it should display Continue Download. Paused game shouldn't be displayed in the completed section but rather in it own (paused section).

@AlexBoXY
Copy link

AlexBoXY commented Mar 13, 2023

I think you don't need another section. It will be clear, when you rename the cancel-button to Pause and if paused, put the game back into the queue section with a continue and abort/remove button.
Less effort and understandable for everybody...

@arielj
Copy link
Collaborator

arielj commented Oct 22, 2023

Is the current approach better? Now we have a Pause Download/Resume Download button.

If that's enough I could close this issue.

@d3d43
Copy link
Author

d3d43 commented Oct 22, 2023

Is the current approach better? Now we have a Pause Download/Resume Download button.

If that's enough I could close this issue.

Unfortunately I am no longer using the application. Please feel free to consult other users if the thread is suited to be left up, or close the issue at your discretion.

@cookiEoverdose
Copy link

It is still happening, you lose a lot of download progress on pause + resume.

@ckblau
Copy link

ckblau commented Feb 16, 2024

It is still happening, you lose a lot of download progress on pause + resume.

Same here, I guess pause/resume only works file-wide, so uncompleted download progress for large files would just gone.

@jackman105
Copy link

Can also confirm that the issue is still present (Official AUR package).

I have tried canceling and resuming both smaller downloads with ~700 MB, as well as larger ones with 5+ GB already downloaded, but the result is the same:

First, the downloader often times (though not always) doesn't properly exit (gogdl as well as some Heroic processes keep running and downloading, even after Heroic itself has been closed, and must be killed from a system monitor).

Then, after all processes have been terminated (gracefully or not) and Heroic restarted, the install dialog will display the already downloaded amount correctly, but upon re-launching the download, it will again start at 0%, without showing any errors in the logs.

Considering that this is an ongoing issue since 2022, may I suggest adding a warning within the application that the resume feature is experimental and should not be relied upon?

Because otherwise a lot of people's time might end up being wasted, when they cannot resume their download which they expected to be able to do (especially on slow connections).

And on a side note: why are there two pause buttons?
One that says "pause", and the other "pause/cancel"?
I mean the difference is irrelevant when neither of them work reliably, but it is still needlessly confusing for end users.

@RikardtheCard
Copy link

I had 60% of a game downloaded with Heroic launcher. Had to do a hard reboot because the computer froze and I couldn't do anything; couldn't even see the cursor. When the computer restarted and I run the launcher the game started at 0% again. If it happens again I guess I am done with Epic and their idiotic launcher.

@RikardtheCard
Copy link

RikardtheCard commented Apr 13, 2024

Haha on me. I decided to leave the Heroic downloading all night thinking if I just left everything alone the 3 games would download by morning. There was a warning that Thief couldn't download because some folder couldn't be found. Weirdly enough a different game did download. Unfortunately, the computer was frozen and I had to hard reboot. Nope, system screwed and wouldn't boot. Fortunately, I had a backup from just a few days previous. I ran Linux live, grabbed a few files so I didn't lose them, installed Timeshift and grabbed the backup. Ditched the whole Epic games idea fiasco. I have better things to do. Had a problem with Ubisoft too...couldn't even sign in to use a bought game. No more third party launchers for me. If I can't get a game using only Steam then I won't get it.

@pw-64
Copy link

pw-64 commented Apr 25, 2024

This issue is still happening. I paused a game download with 30 mins left cause I wanted to watch youtube. Finished the video then clicked resume and the timer went back up to 1 hour 30 mins and 0%. It can't be called pause and resume if it actually just cancels then restarts the download.

Heroic version 2.14.1

@jackman105
Copy link

After having the resume fail to work for anywhere between half a dozen to a whole dozen times in a row since I installed Heroic, I recently encountered a situation where it did work out of the blue.

The situation was exactly the same as I described in my previous post, with Heroic failing to exit properly on pause, and having to terminate the process using a system monitor.

But when I returned to download it again a few days later, it did actually resume the download from the ~800mb which had already been downloaded, rather than starting from 0%.

So while the feature initially didn't work for me at all, it now appears that it "only" fails to work most of the time, but not always.

@pw-64
Copy link

pw-64 commented Oct 11, 2024

@Heroic-Games-Launcher this issue has been open almost 2 years and is still causing a major problem to this day. Are there any updates?

As a minimum, there should be a warning that the feature doesn't work as expected to remind users to be careful, as @jackman105 suggested.

This can be a real problem for people, like myself, with data caps and/or very slow internet speeds, where restarting the download has a huge impact and actually costs a lot of money and time.

@arielj
Copy link
Collaborator

arielj commented Jan 9, 2025

I'm not completely sure, but I think this could fix it? #4240

@arielj
Copy link
Collaborator

arielj commented Jan 9, 2025

to be clear, we are volunteers here and PRs are welcomed, anybody can contribute, not just the heroic main team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants