From 750085a88bc47395fbffd07adca052d7843118ed Mon Sep 17 00:00:00 2001 From: Nico Matentzoglu Date: Sat, 10 Oct 2026 00:46:24 +0300 Subject: [PATCH] Allow dosdp_validation in PAT=false In QC we tend to not run dosdp patterns (PAT=false); but validating the dosdp patterns themselves is actually important during QC and takes only a few seconds to do. Here, we make it possible to run dosdp_validation regardless of how PAT is set. --- .../odk/templates/src/ontology/Makefile.jinja2 | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/src/incatools/odk/templates/src/ontology/Makefile.jinja2 b/src/incatools/odk/templates/src/ontology/Makefile.jinja2 index c2b5797..dd99727 100644 --- a/src/incatools/odk/templates/src/ontology/Makefile.jinja2 +++ b/src/incatools/odk/templates/src/ontology/Makefile.jinja2 @@ -1111,18 +1111,19 @@ EXTERNAL_PATTERN_FILES = $(notdir $(EXTERNAL_PATTERN_URLS)) pattern_clean: rm -f $(PATTERN_CLEAN_FILES) -ifeq ($(PAT),true) - -.PHONY: patterns dosdp -patterns dosdp: dosdp_validation $(PATTERNDIR)/pattern.owl $(PATTERNDIR)/definitions.owl - -.PHONY: pattern_schema_checks +# Validation only reads the pattern files, so it runs regardless of PAT +.PHONY: pattern_schema_checks dosdp_validation pattern_schema_checks dosdp_validation: $(TMPDIR)/stamp-pattern-schema-checks $(TMPDIR)/stamp-pattern-schema-checks: $(ALL_PATTERN_FILES) | $(TMPDIR) $(PATTERN_TESTER) $(PATTERNDIR)/dosdp-patterns touch $@ +ifeq ($(PAT),true) + +.PHONY: patterns dosdp +patterns dosdp: dosdp_validation $(PATTERNDIR)/pattern.owl $(PATTERNDIR)/definitions.owl + .PHONY: download_patterns download_patterns: | $(TMPDIR) mkdir -p $(TMPDIR)/dosdp @@ -1307,9 +1308,6 @@ else # PAT=false $(TMPDIR)/all_pattern_terms.txt: $(PATTERNDIR)/definitions.owl $(ROBOT) query --input $< --use-graphs true --format csv \ --query $(SPARQLDIR)/terms.sparql $@ - -# Dummy target to allow "make test" to skip DOSDP validation under PAT=false -dosdp_validation: endif