Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need help understanding where URI Encoding happens #219

Closed
6d6178 opened this issue Sep 2, 2019 · 3 comments
Closed

Need help understanding where URI Encoding happens #219

6d6178 opened this issue Sep 2, 2019 · 3 comments
Labels
area/backend Affects the graphite backend

Comments

@6d6178
Copy link

6d6178 commented Sep 2, 2019

Hi,
I'm currently trying to use carbonapi (and maybe even metrictank) as backend for this module. I already figured out how to replace the expand url with a find. Now I'm struggling with the render URI. The URI is encoded at some point to this pattern: render?from=1567412279\u0026until=1567415879\u0026width=1112.22\u0026height=220\u0026
carbonapi wants an & though, so this doesn't work. I already searched the code for the place where the encoding (decoding?) happens, but I can't find it. Can anyone help me out?
The URI is built in library/Graphite/Web/Widget/GraphImage.php and then does a request, but there is no mention of en/decoding.
Of course I plan to make a Pull Request once it works.

@dnsmichi dnsmichi added the area/backend Affects the graphite backend label Jan 10, 2020
@yoshi314
Copy link

yoshi314 commented Oct 8, 2021

i am also interested in this, since switching to carbinapi i have different urls than what module makes.

@nilmerg
Copy link
Member

nilmerg commented Mar 11, 2024

I'm not aware of any encoding the module does here. & is the default parameter separator.

@nilmerg
Copy link
Member

nilmerg commented Mar 11, 2024

Duplicate of #300

@nilmerg nilmerg marked this as a duplicate of #300 Mar 11, 2024
@nilmerg nilmerg closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Affects the graphite backend
Projects
None yet
Development

No branches or pull requests

4 participants