From ecf46fe14b3808fb9b591869dcb45053c412edd1 Mon Sep 17 00:00:00 2001 From: Joao Dordio Date: Thu, 19 Sep 2024 16:20:51 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=97=91=EF=B8=8F=20Removed=20Iterable=20sp?= =?UTF-8?q?ecific=20identifiers=20and=20hardcoded=20URLs=20to=20use=20gene?= =?UTF-8?q?ric=20ones=20instead=20on=20the=20sample=20app.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../objc-sample-app/AppDelegate.m | 2 +- .../objc-sample-app/objc-sample-app.entitlements | 4 ++-- .../swift-sample-app.xcodeproj/project.pbxproj | 16 ++++++++-------- .../swift-sample-app/AppDelegate.swift | 2 +- .../swift-sample-app.entitlements | 4 ++-- 5 files changed, 14 insertions(+), 14 deletions(-) diff --git a/sample-apps/objc-sample-app/objc-sample-app/AppDelegate.m b/sample-apps/objc-sample-app/objc-sample-app/AppDelegate.m index 81c2c0a24..55777257d 100644 --- a/sample-apps/objc-sample-app/objc-sample-app/AppDelegate.m +++ b/sample-apps/objc-sample-app/objc-sample-app/AppDelegate.m @@ -134,7 +134,7 @@ - (BOOL)handleIterableURL:(NSURL *)url context:(IterableActionContext *)context - (BOOL)handleIterableCustomAction:(IterableAction *)action context:(IterableActionContext *)context { if ([action.type isEqualToString:@"handleFindCoffee"]) { if (action.userInput != nil) { - NSString *urlString = [[NSString alloc] initWithFormat:@"https://majumder.me/coffee?q=%@", action.userInput]; + NSString *urlString = [[NSString alloc] initWithFormat:@"https://example.com/coffee?q=%@", action.userInput]; NSURL *url = [[NSURL alloc] initWithString:urlString]; return [DeepLinkHandler handleURL:url]; } diff --git a/sample-apps/objc-sample-app/objc-sample-app/objc-sample-app.entitlements b/sample-apps/objc-sample-app/objc-sample-app/objc-sample-app.entitlements index dc55c693a..8e3e75563 100644 --- a/sample-apps/objc-sample-app/objc-sample-app/objc-sample-app.entitlements +++ b/sample-apps/objc-sample-app/objc-sample-app/objc-sample-app.entitlements @@ -6,8 +6,8 @@ development com.apple.developer.associated-domains - applinks:majumder.me - applinks:links.majumder.me + applinks:example.com + applinks:links.example.com diff --git a/sample-apps/swift-sample-app/swift-sample-app.xcodeproj/project.pbxproj b/sample-apps/swift-sample-app/swift-sample-app.xcodeproj/project.pbxproj index cce01444d..be948faa3 100644 --- a/sample-apps/swift-sample-app/swift-sample-app.xcodeproj/project.pbxproj +++ b/sample-apps/swift-sample-app/swift-sample-app.xcodeproj/project.pbxproj @@ -489,13 +489,13 @@ ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; CODE_SIGN_ENTITLEMENTS = "swift-sample-app/swift-sample-app.entitlements"; CODE_SIGN_STYLE = Automatic; - DEVELOPMENT_TEAM = BP98Z28R86; + DEVELOPMENT_TEAM = ""; INFOPLIST_FILE = "swift-sample-app/Info.plist"; LD_RUNPATH_SEARCH_PATHS = ( "$(inherited)", "@executable_path/Frameworks", ); - PRODUCT_BUNDLE_IDENTIFIER = "iterable.swift-sample-app"; + PRODUCT_BUNDLE_IDENTIFIER = "com.example.iterable.swift-sample-app"; PRODUCT_NAME = "$(TARGET_NAME)"; SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; @@ -508,13 +508,13 @@ ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; CODE_SIGN_ENTITLEMENTS = "swift-sample-app/swift-sample-app.entitlements"; CODE_SIGN_STYLE = Automatic; - DEVELOPMENT_TEAM = BP98Z28R86; + DEVELOPMENT_TEAM = ""; INFOPLIST_FILE = "swift-sample-app/Info.plist"; LD_RUNPATH_SEARCH_PATHS = ( "$(inherited)", "@executable_path/Frameworks", ); - PRODUCT_BUNDLE_IDENTIFIER = "iterable.swift-sample-app"; + PRODUCT_BUNDLE_IDENTIFIER = "com.example.iterable.swift-sample-app"; PRODUCT_NAME = "$(TARGET_NAME)"; SWIFT_VERSION = 5.0; TARGETED_DEVICE_FAMILY = "1,2"; @@ -525,14 +525,14 @@ isa = XCBuildConfiguration; buildSettings = { CODE_SIGN_STYLE = Automatic; - DEVELOPMENT_TEAM = BP98Z28R86; + DEVELOPMENT_TEAM = ""; INFOPLIST_FILE = "swift-sample-app-notification-extension/Info.plist"; LD_RUNPATH_SEARCH_PATHS = ( "$(inherited)", "@executable_path/Frameworks", "@executable_path/../../Frameworks", ); - PRODUCT_BUNDLE_IDENTIFIER = "iterable.swift-sample-app.swift-sample-app-notification-extension"; + PRODUCT_BUNDLE_IDENTIFIER = "com.example.iterable.swift-sample-app.swift-sample-app-notification-extension"; PRODUCT_NAME = "$(TARGET_NAME)"; SKIP_INSTALL = YES; SWIFT_VERSION = 5.0; @@ -544,14 +544,14 @@ isa = XCBuildConfiguration; buildSettings = { CODE_SIGN_STYLE = Automatic; - DEVELOPMENT_TEAM = BP98Z28R86; + DEVELOPMENT_TEAM = ""; INFOPLIST_FILE = "swift-sample-app-notification-extension/Info.plist"; LD_RUNPATH_SEARCH_PATHS = ( "$(inherited)", "@executable_path/Frameworks", "@executable_path/../../Frameworks", ); - PRODUCT_BUNDLE_IDENTIFIER = "iterable.swift-sample-app.swift-sample-app-notification-extension"; + PRODUCT_BUNDLE_IDENTIFIER = "com.example.iterable.swift-sample-app.swift-sample-app-notification-extension"; PRODUCT_NAME = "$(TARGET_NAME)"; SKIP_INSTALL = YES; SWIFT_VERSION = 5.0; diff --git a/sample-apps/swift-sample-app/swift-sample-app/AppDelegate.swift b/sample-apps/swift-sample-app/swift-sample-app/AppDelegate.swift index c7b968506..b0c80f51a 100644 --- a/sample-apps/swift-sample-app/swift-sample-app/AppDelegate.swift +++ b/sample-apps/swift-sample-app/swift-sample-app/AppDelegate.swift @@ -165,7 +165,7 @@ extension AppDelegate: IterableCustomActionDelegate { func handle(iterableCustomAction action: IterableAction, inContext _: IterableActionContext) -> Bool { if action.type == "handleFindCoffee" { if let query = action.userInput { - return DeepLinkHandler.handle(url: URL(string: "https://majumder.me/coffee?q=\(query)")!) + return DeepLinkHandler.handle(url: URL(string: "https://example.com/coffee?q=\(query)")!) } } return false diff --git a/sample-apps/swift-sample-app/swift-sample-app/swift-sample-app.entitlements b/sample-apps/swift-sample-app/swift-sample-app/swift-sample-app.entitlements index dc55c693a..8e3e75563 100644 --- a/sample-apps/swift-sample-app/swift-sample-app/swift-sample-app.entitlements +++ b/sample-apps/swift-sample-app/swift-sample-app/swift-sample-app.entitlements @@ -6,8 +6,8 @@ development com.apple.developer.associated-domains - applinks:majumder.me - applinks:links.majumder.me + applinks:example.com + applinks:links.example.com