|
| 1 | +/*- |
| 2 | + * #%L |
| 3 | + * JSQLParser library |
| 4 | + * %% |
| 5 | + * Copyright (C) 2004 - 2026 JSQLParser |
| 6 | + * %% |
| 7 | + * Dual licensed under GNU LGPL 2.1 or Apache License 2.0 |
| 8 | + * #L% |
| 9 | + */ |
| 10 | +package net.sf.jsqlparser.statement.select; |
| 11 | + |
| 12 | +import static org.junit.jupiter.api.Assertions.assertEquals; |
| 13 | +import static org.junit.jupiter.api.Assertions.assertNull; |
| 14 | +import static org.junit.jupiter.api.Assertions.assertThrows; |
| 15 | +import java.util.List; |
| 16 | +import java.util.Set; |
| 17 | +import net.sf.jsqlparser.JSQLParserException; |
| 18 | +import net.sf.jsqlparser.parser.AbstractJSqlParser.Dialect; |
| 19 | +import net.sf.jsqlparser.parser.CCJSqlParserUtil; |
| 20 | +import net.sf.jsqlparser.schema.Table; |
| 21 | +import net.sf.jsqlparser.statement.Statement; |
| 22 | +import net.sf.jsqlparser.test.TestUtils; |
| 23 | +import net.sf.jsqlparser.util.TablesNamesFinder; |
| 24 | +import net.sf.jsqlparser.util.deparser.StatementDeParser; |
| 25 | +import org.junit.jupiter.api.Test; |
| 26 | +import org.junit.jupiter.params.ParameterizedTest; |
| 27 | +import org.junit.jupiter.params.provider.ValueSource; |
| 28 | + |
| 29 | +class DorisJoinHintTest { |
| 30 | + private static PlainSelect parse(String sql, Dialect dialect) throws JSQLParserException { |
| 31 | + return (PlainSelect) CCJSqlParserUtil.parse(sql, parser -> parser.withDialect(dialect)); |
| 32 | + } |
| 33 | + |
| 34 | + @Test |
| 35 | + void parsesOriginalReproducerIssue1620() throws Exception { |
| 36 | + String sql = "SELECT * FROM uba.events a LEFT JOIN [shuffle] uba.events b " |
| 37 | + + "ON a.event_id = b.event_id"; |
| 38 | + PlainSelect select = (PlainSelect) TestUtils.assertSqlCanBeParsedAndDeparsed(sql, false, |
| 39 | + parser -> parser.withDialect(Dialect.DORIS)); |
| 40 | + Join join = select.getJoins().get(0); |
| 41 | + assertEquals("shuffle", join.getJoinHint().getKeyword()); |
| 42 | + assertEquals(JoinHint.Position.AFTER_JOIN, join.getJoinHint().getPosition()); |
| 43 | + assertEquals("uba.events", ((Table) join.getFromItem()).getFullyQualifiedName()); |
| 44 | + assertEquals("b", join.getFromItem().getAlias().getName()); |
| 45 | + assertEquals(Set.of("uba.events"), new TablesNamesFinder<>().getTables((Statement) select)); |
| 46 | + } |
| 47 | + |
| 48 | + @ParameterizedTest |
| 49 | + @ValueSource(strings = {"shuffle", "broadcast", "SHUFFLE", "BROADCAST"}) |
| 50 | + void preservesHintPositionAndRoundTrips(String hint) throws Exception { |
| 51 | + for (String kind : List.of("", "INNER ", "LEFT OUTER ", "RIGHT ", "LEFT SEMI ")) { |
| 52 | + String sql = "SELECT a.id FROM a " + kind + "JOIN [" + hint + "] b USING (id)"; |
| 53 | + PlainSelect select = (PlainSelect) TestUtils.assertSqlCanBeParsedAndDeparsed(sql, false, |
| 54 | + parser -> parser.withDialect(Dialect.DORIS)); |
| 55 | + StringBuilder output = new StringBuilder(); |
| 56 | + select.accept(new StatementDeParser(output), null); |
| 57 | + for (String rendered : List.of(select.toString(), output.toString())) { |
| 58 | + JoinHint reparsed = parse(rendered, Dialect.DORIS).getJoins().get(0).getJoinHint(); |
| 59 | + assertEquals(hint, reparsed.getKeyword()); |
| 60 | + assertEquals(JoinHint.Position.AFTER_JOIN, reparsed.getPosition()); |
| 61 | + } |
| 62 | + } |
| 63 | + } |
| 64 | + |
| 65 | + @Test |
| 66 | + void keepsHintPerJoinAndSupportsAstMutation() throws Exception { |
| 67 | + PlainSelect select = parse("SELECT * FROM a JOIN [shuffle] b ON a.id = b.id " |
| 68 | + + "JOIN [broadcast] c ON b.id = c.id JOIN d ON c.id = d.id", Dialect.DORIS); |
| 69 | + assertEquals("shuffle", select.getJoins().get(0).getJoinHint().getKeyword()); |
| 70 | + assertEquals("broadcast", select.getJoins().get(1).getJoinHint().getKeyword()); |
| 71 | + assertNull(select.getJoins().get(2).getJoinHint()); |
| 72 | + select.getJoins().get(0) |
| 73 | + .setJoinHint(new JoinHint("broadcast", JoinHint.Position.AFTER_JOIN)); |
| 74 | + TestUtils.assertDeparse(select, "SELECT * FROM a JOIN [broadcast] b ON a.id = b.id " |
| 75 | + + "JOIN [broadcast] c ON b.id = c.id JOIN d ON c.id = d.id"); |
| 76 | + select.getJoins().get(0).setJoinHint(null); |
| 77 | + assertEquals("JOIN b ON a.id = b.id", select.getJoins().get(0).toString()); |
| 78 | + } |
| 79 | + |
| 80 | + @Test |
| 81 | + void keepsSqlServerHintsAndQuotedTableNames() throws Exception { |
| 82 | + for (String keyword : List.of("LOOP", "HASH", "MERGE", "REMOTE")) { |
| 83 | + String sql = "SELECT * FROM a INNER " + keyword + " JOIN b ON a.id = b.id"; |
| 84 | + PlainSelect select = (PlainSelect) TestUtils.assertSqlCanBeParsedAndDeparsed(sql); |
| 85 | + assertEquals(JoinHint.Position.BEFORE_JOIN, |
| 86 | + select.getJoins().get(0).getJoinHint().getPosition()); |
| 87 | + assertEquals(keyword, new JoinHint(keyword).toString()); |
| 88 | + } |
| 89 | + PlainSelect quoted = parse("SELECT * FROM a JOIN [shuffle] b ON a.id = b.id", |
| 90 | + Dialect.SQLSERVER); |
| 91 | + assertNull(quoted.getJoins().get(0).getJoinHint()); |
| 92 | + assertEquals("[shuffle]", ((Table) quoted.getJoins().get(0).getFromItem()).getName()); |
| 93 | + PlainSelect dorisTable = parse("SELECT * FROM a JOIN `shuffle` b ON a.id = b.id", |
| 94 | + Dialect.DORIS); |
| 95 | + assertNull(dorisTable.getJoins().get(0).getJoinHint()); |
| 96 | + } |
| 97 | + |
| 98 | + @Test |
| 99 | + void requiresDorisDialect() { |
| 100 | + String sql = "SELECT * FROM a JOIN [shuffle] db.b b ON a.id = b.id"; |
| 101 | + assertThrows(JSQLParserException.class, () -> CCJSqlParserUtil.parse(sql)); |
| 102 | + for (Dialect dialect : Dialect.values()) { |
| 103 | + if (dialect != Dialect.DORIS) { |
| 104 | + assertThrows(JSQLParserException.class, () -> parse(sql, dialect), dialect.name()); |
| 105 | + } |
| 106 | + } |
| 107 | + } |
| 108 | + |
| 109 | + @Test |
| 110 | + void rejectsUnknownAndDuplicateHints() { |
| 111 | + for (String sql : List.of("SELECT * FROM a JOIN [unknown] b ON a.id = b.id", |
| 112 | + "SELECT * FROM a JOIN [shuffle, broadcast] b ON a.id = b.id", |
| 113 | + "SELECT * FROM a JOIN [shuffle] [broadcast] b ON a.id = b.id", |
| 114 | + "SELECT * FROM a INNER HASH JOIN [shuffle] b ON a.id = b.id", |
| 115 | + "SELECT * FROM a JOIN [shuffle b ON a.id = b.id")) { |
| 116 | + assertThrows(JSQLParserException.class, () -> parse(sql, Dialect.DORIS), sql); |
| 117 | + } |
| 118 | + } |
| 119 | +} |
0 commit comments