From a4257e5950d42898535c5997d9fca9ab39e7c670 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Josh=20Goldberg=20=E2=9C=A8?= Date: Fri, 20 Dec 2024 17:23:06 -0500 Subject: [PATCH] fix: remove unnecessary default values from .all-contributorsrc (#1784) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## PR Checklist - [x] Addresses an existing open issue: fixes #1783 - [x] That issue was marked as [`status: accepting prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22) - [x] Steps in [CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md) were taken ## Overview Straightforward removal of config settings. Note the lack of actual changes to the `README.md` file. 🔪 --- .all-contributorsrc | 12 +----------- src/next/blocks/blockAllContributors.test.ts | 4 ++-- src/next/blocks/blockAllContributors.ts | 8 -------- src/steps/writing/creation/writeAllContributorsRC.ts | 8 -------- 4 files changed, 3 insertions(+), 29 deletions(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index 5abbf2c31..eb6f04775 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -1,8 +1,5 @@ { "badgeTemplate": "\t\"👪\" src=\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\" />", - "commit": false, - "commitConvention": "angular", - "commitType": "docs", "contributors": [ { "avatar_url": "https://avatars.githubusercontent.com/u/3335181?v=4", @@ -483,14 +480,7 @@ ] } ], - "contributorsPerLine": 7, "contributorsSortAlphabetically": true, - "files": [ - "README.md" - ], - "imageSize": 100, "projectName": "create-typescript-app", - "projectOwner": "JoshuaKGoldberg", - "repoHost": "https://github.com", - "repoType": "github" + "projectOwner": "JoshuaKGoldberg" } diff --git a/src/next/blocks/blockAllContributors.test.ts b/src/next/blocks/blockAllContributors.test.ts index 5de046464..b58163ec5 100644 --- a/src/next/blocks/blockAllContributors.test.ts +++ b/src/next/blocks/blockAllContributors.test.ts @@ -21,7 +21,7 @@ describe("blockAllContributors", () => { }, ], "files": { - ".all-contributorsrc": "{"badgeTemplate":"\\t\\"👪\\" src=\\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\\" />","commit":false,"commitConvention":"angular","commitType":"docs","contributors":[],"contributorsPerLine":7,"contributorsSortAlphabetically":true,"files":["README.md"],"imageSize":100,"projectName":"test-repository","projectOwner":"test-owner","repoHost":"https://github.com","repoType":"github"}", + ".all-contributorsrc": "{"badgeTemplate":"\\t\\"👪\\" src=\\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\\" />","contributors":[],"contributorsSortAlphabetically":true,"projectName":"test-repository","projectOwner":"test-owner"}", ".github": { "workflows": { "contributors.yml": "jobs: @@ -88,7 +88,7 @@ describe("blockAllContributors", () => { }, ], "files": { - ".all-contributorsrc": "{"badgeTemplate":"\\t\\"👪\\" src=\\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\\" />","commit":false,"commitConvention":"angular","commitType":"docs","contributors":[{"avatar_url":"https://avatars.githubusercontent.com/u/3335181?v=4","contributions":["bug","ideas"],"login":"JoshuaKGoldberg","name":"Josh Goldberg","profile":"http://www.joshuakgoldberg.com"}],"contributorsPerLine":7,"contributorsSortAlphabetically":true,"files":["README.md"],"imageSize":100,"projectName":"test-repository","projectOwner":"test-owner","repoHost":"https://github.com","repoType":"github"}", + ".all-contributorsrc": "{"badgeTemplate":"\\t\\"👪\\" src=\\"https://img.shields.io/badge/%F0%9F%91%AA_all_contributors-<%= contributors.length %>-21bb42.svg\\" />","contributors":[{"avatar_url":"https://avatars.githubusercontent.com/u/3335181?v=4","contributions":["bug","ideas"],"login":"JoshuaKGoldberg","name":"Josh Goldberg","profile":"http://www.joshuakgoldberg.com"}],"contributorsSortAlphabetically":true,"projectName":"test-repository","projectOwner":"test-owner"}", ".github": { "workflows": { "contributors.yml": "jobs: diff --git a/src/next/blocks/blockAllContributors.ts b/src/next/blocks/blockAllContributors.ts index 5391d6ce0..942cad691 100644 --- a/src/next/blocks/blockAllContributors.ts +++ b/src/next/blocks/blockAllContributors.ts @@ -18,18 +18,10 @@ export const blockAllContributors = base.createBlock({ ".all-contributorsrc": JSON.stringify({ badgeTemplate: ' 👪 All Contributors: <%= contributors.length %>', - commit: false, - commitConvention: "angular", - commitType: "docs", contributors: options.contributors ?? [], - contributorsPerLine: 7, contributorsSortAlphabetically: true, - files: ["README.md"], - imageSize: 100, projectName: options.repository, projectOwner: options.owner, - repoHost: "https://github.com", - repoType: "github", }), ".github": { workflows: { diff --git a/src/steps/writing/creation/writeAllContributorsRC.ts b/src/steps/writing/creation/writeAllContributorsRC.ts index b47a382d2..9af327a99 100644 --- a/src/steps/writing/creation/writeAllContributorsRC.ts +++ b/src/steps/writing/creation/writeAllContributorsRC.ts @@ -10,17 +10,9 @@ export async function writeAllContributorsRC(options: Options) { return await formatJson({ badgeTemplate: ' 👪 All Contributors: <%= contributors.length %>', - commit: false, - commitConvention: "angular", - commitType: "docs", contributors: existing?.contributors ?? [], - contributorsPerLine: 7, contributorsSortAlphabetically: true, - files: ["README.md"], - imageSize: 100, projectName: options.repository, projectOwner: options.owner, - repoHost: "https://github.com", - repoType: "github", }); }