Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecisionTree doesn't handle multiclass input? #134

Closed
tlienart opened this issue Nov 18, 2019 · 2 comments
Closed

DecisionTree doesn't handle multiclass input? #134

tlienart opened this issue Nov 18, 2019 · 2 comments

Comments

@tlienart
Copy link
Collaborator

tlienart commented Nov 18, 2019

Their readme clearly states that it handles cateogircals yet the input_scitype is marked as Continuous and it indeed seems that it does not in fact handle categoricals because it needs to be able to define a isless operation?

Opening an issue on DecisionTree as well for clarifications: https://github.com/bensadeghi/DecisionTree.jl/issues/92

@ablaom
Copy link
Member

ablaom commented Nov 28, 2019

I think this has now been clarified at the above thread. The DecisionTree input_scitypes could be updated to Table(Continuous, OrderedFactor, Count) but with a comment in the doc-string that coercion of OrderedFactor columns to Count or Continuous may lead to better performance, without affecting outcomes.

@ablaom
Copy link
Member

ablaom commented Nov 28, 2019

To be clear, Multiclass is not strictly supported. If such data is coerced to one of the other ordered types, by choosing an ordering, then the outcome of training will depend on that choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants