Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release 2.10 for Unicode 16 support #280

Closed
eschnett opened this issue Dec 29, 2024 · 3 comments · Fixed by #281
Closed

New release 2.10 for Unicode 16 support #280

eschnett opened this issue Dec 29, 2024 · 3 comments · Fixed by #281

Comments

@eschnett
Copy link
Collaborator

I'd like to have / create a new release 2.10 that supports Unicode 16. I'd be happy to create the release if others give the go-ahead.

(January 8 will be the feature freeze for Julia 1.12; if possible I'd like to have Unicode 16 in Julia 1.12.)

@clason
Copy link

clason commented Dec 30, 2024

@stevengj

(and that would close #272 as well)

@stevengj
Copy link
Member

I've put together a candidate release PR #281, please take a look.

Once the release is tagged, there is also some rigamarole to update the gh-pages branch for the website.

@stevengj
Copy link
Member

stevengj commented Dec 31, 2024

I'm getting some warnings that it would be good to fix:

utf8proc.c:702:28: warning: implicit conversion changes signedness: 'utf8proc_uint32_t' (aka 'unsigned int') to 'utf8proc_int32_t' (aka 'int') [-Wsign-conversion]
  702 |                 *starter = composition;
      |                          ~ ^~~~~~~~~~~
utf8proc.c:691:28: warning: comparison of integers of different signs: 'utf8proc_int32_t' (aka 'int') and 'utf8proc_uint32_t' (aka 'unsigned int') [-Wsign-compare]
  691 |           if (current_char <= max_second) {
      |               ~~~~~~~~~~~~ ^  ~~~~~~~~~~
utf8proc.c:695:32: warning: comparison of integers of different signs: 'utf8proc_int32_t' (aka 'int') and 'utf8proc_uint32_t' (aka 'unsigned int') [-Wsign-compare]
  695 |               if (current_char < second) {
      |                   ~~~~~~~~~~~~ ^ ~~~~~~
utf8proc.c:699:32: warning: comparison of integers of different signs: 'utf8proc_int32_t' (aka 'int') and 'utf8proc_uint32_t' (aka 'unsigned int') [-Wsign-compare]
  699 |               if (current_char == second) {

Update: fixed in #282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants