Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Over-midnight period #20

Open
nlehuby opened this issue Jul 27, 2020 · 8 comments
Open

Over-midnight period #20

nlehuby opened this issue Jul 27, 2020 · 8 comments

Comments

@nlehuby
Copy link
Member

nlehuby commented Jul 27, 2020

I can't get working this use case: a night bus with the following schedule
image

  • from 21h50 to 1h20, every 35 min
  • from 1h20 to 3h20, every hour
  • from 3h20 to 6h50, every 35 min

The following form
Screenshot_2020-07-27 Busy Hours(2)
is turned to that, when the page is reloaded (the over-midnight period is removed)
Screenshot_2020-07-27 Busy Hours(3)

And the following form, that cuts the over-midnight period into two regular periods, with start time < end time is ko too
Screenshot_2020-07-27 Busy Hours
turned into:
Screenshot_2020-07-27 Busy Hours(1)

@nlehuby
Copy link
Member Author

nlehuby commented Jul 27, 2020

🤔 maybe a parsing issue (in transport-hours) actually

@PanierAvide
Copy link
Collaborator

Right, there was an issue in transport-hours, I fixed it : Jungle-Bus/transport-hours-js@dce3135

You can update dependency and re-deploy, this should fix this issue.

@nlehuby
Copy link
Member Author

nlehuby commented Aug 3, 2020

thanks 👍

The python3 version is broken though: https://travis-ci.org/github/Jungle-Bus/transport-hours-py

@PanierAvide
Copy link
Collaborator

Fix for the fix 😅 Jungle-Bus/transport-hours-py@a2653ff

@nlehuby
Copy link
Member Author

nlehuby commented Aug 3, 2020

👌 can you re-release it on pypi please ?

@PanierAvide
Copy link
Collaborator

Done

@nlehuby
Copy link
Member Author

nlehuby commented Aug 6, 2020

EDIT - I've updated the lib on Busy Hours deployment, but I can still reproduce this issue:

@nlehuby
Copy link
Member Author

nlehuby commented Feb 11, 2022

hum, the remaining issue seems to be the same as #24 (no interval exception on the before midnight part, so it is skipped)

opening_hours Mo-Su,PH 01:20-06:45,21:50-01:20
interval 35
interval:conditional 60 @ (Mo-Su,PH 01:20-03:20)

ends up as:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants