Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modelcatalog_reduced does not validate anymore #145

Closed
dgarijo opened this issue Oct 24, 2020 · 4 comments
Closed

modelcatalog_reduced does not validate anymore #145

dgarijo opened this issue Oct 24, 2020 · 4 comments
Assignees
Labels
bug Something isn't working high priority
Milestone

Comments

@dgarijo
Copy link
Contributor

dgarijo commented Oct 24, 2020

When I created this example ontology, it would validate in the swagger editor. Now it doesn't despite all tests being passed. For some reason, some schemas are not being added to the spec.

I am going to incorporate an OpenAPI validator (https://github.com/openapi4j/openapi4j) to our tests, to make sure that every OpenAPI conforms to the spec.

@dgarijo dgarijo added bug Something isn't working high priority labels Oct 24, 2020
@dgarijo dgarijo self-assigned this Oct 24, 2020
@dgarijo
Copy link
Contributor Author

dgarijo commented Oct 24, 2020

This is due to having classes under imported subclasses with the same name. We should:

  1. Have an example for the model catalog with no duplicate names in classes.
  2. Have a smaller example for testing the above issue.

@dgarijo
Copy link
Contributor Author

dgarijo commented Oct 26, 2020

@dgarijo
Copy link
Contributor Author

dgarijo commented Oct 28, 2020

The reason for this is not necessarily an error from OBA. Model catalog reduced imports another ontology which is not included. Therefore, the paths of those classes will not be added into the schemas. However, some properties reuse them (because they extend them). We should validate the spec; but we should leave the resolving of the ontologies to include to the user with (see #147)

@dgarijo
Copy link
Contributor Author

dgarijo commented Oct 29, 2020

Closing, as this issue seems to be addressed. Will keep open #133 to validate openapi

@dgarijo dgarijo closed this as completed Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority
Projects
None yet
Development

No branches or pull requests

1 participant