Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't implement AutoClosable on AudienceProvider #143

Open
kezz opened this issue Nov 22, 2023 · 0 comments
Open

Don't implement AutoClosable on AudienceProvider #143

kezz opened this issue Nov 22, 2023 · 0 comments
Labels
type: enhancement New feature or request

Comments

@kezz
Copy link
Member

kezz commented Nov 22, 2023

This makes IDEs and other linting tools nag at you for not using try-with-resources and for not closing it. It's not really necessary nor particularly useful in this case for it to exist. It also gives the impression that the audience providers should be used like other AutoClosable objects, like database connections or input streams (where you spin one up, use it and close it) which is not the case.

@kezz kezz added the type: enhancement New feature or request label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant